Conversation
…rder of the integer they depict.
…ly interpret signed values.
Author
|
I have drastically improved the performance of this interface by hard-wiring an ethernet connection to the inverter rather than using the wifi dongle. Modbus communication failures have completely gone away. It's quite likely the modbus re-connection change I made in this branch are unnecessary. |
Author
|
@ptarcher Ping! Are you alive? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a fair few modifications to how the interface works. I've added the registers that the SH5k-20 holds, as well as added a type key to the register map per register, to allow for translation to signed values before publishing to MQTT.
I slightly reworked how modbus reconnects are handled.
I'm still not entirely happy with this interface. Sometimes the inverter stops responding to modbus requests for a while. I'm not sure if this is a timing issue, or whether the inverter doesn't properly implement modbus, or what. It's a little annoying.
In any case, this is a better starting point for someone wanting to get data from an SH5k-20 using pvstats than not having it at all.
I also stored the registers using integer keys, not strings, since they sort correctly. When adding registers in the 13000 range they sorted to before the registers in the 5000 range, causing difficulties.