Repository navigation
Conversation
…ads (#3530) ## Summary Answers [#1612](#1612). The issue closes on the promotion pull request. `GOVERNANCE.md` "Editor and Tasks" named `.vscode/settings.json` and `.vscode/extensions.json` to forbid them. The prose gate's `dead-path` rule reads a backtick span containing a `/` as a path. It reports that path when git once tracked it and the tree no longer holds it. So every carrier that ever deleted `.vscode/settings.json` failed the gate as soon as a re-vendor touched the line. This section is `verbatim`, so the carrier cannot reword it and is held at an old revision. The sentence now names the files by basename "under `.vscode/`". The rule is unchanged. `path_candidate` drops a span with no `/`, and `.vscode/` has no file-shaped last segment, so neither span reaches the deletion check. ## Verification A throwaway repository commits `.vscode/settings.json` and then deletes it. In that repository, `prose_lint.py --check dead-path`: - on the old `GOVERNANCE.md`: `GOVERNANCE.md:354: dead-path: path '.vscode/settings.json' is deleted from this tree`, exit 1 - on the new `GOVERNANCE.md`: no finding, exit 0 The full prose gate on `GOVERNANCE.md` and `spec/validate.py` both pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
## Summary Applies the maintainer's decision on [#2255](#2255): HomeAutomation-Config declares `python`. The issue closes on the promotion pull request. The registry entry now carries: - `types`: `source-only` and `python` - `pythonDirectories`: the eight directories both of the repository's workflows pass to the hub validator's `python-directories` input (CloudInit, Cloudflare, MutationSweep, Notify, Trackers, USBDev, VPS, scripts) - `requiredSecrets`: `CODECOV_TOKEN`, which the repository already stores in both the actions and dependabot stores A new driftNote on the entry records the decision. The committed hub audit `reports/homeautomation-config/audit.md` records the earlier decision on HomeAutomation-Config #438 to keep `python` undeclared, and the maintainer reversed it under #2255. `docs/pre-commit-hooks-rollout.md` now gives HomeAutomation-Config's row the `pre-commit` framework half. Before, it read as a doc-gate-only repository, which a resync would tick as complete. Its box is now checked, because the hub audit in `reports/homeautomation-config/audit.md` graded `parity.hooks` passing with the Python gates included, and the tracker's maintenance rule owes the box once that audit exists. A sweep of every row against the registry found that the hub's own row also omitted its `python` type, and that row is corrected too. It also now names #962, rather than "this PR", as where its ruff/mypy half was added. ## Verification - `spec/validate.py` passes. - `uv run --no-project --script spec/audit.py HomeAutomation-Config`, run against this registry, no longer reports the five findings #2255 tracks: the type, the two `python-directories` findings and the two `CODECOV_TOKEN` secret findings. It raises no new python, profile or secrets finding. ## Pre-existing findings, not filed - `spec/divergences.json:24`, a stale rationale: the `accepted` reason for `.github/actions/validate/action.yml` says HomeAutomation-Config's override runs its CloudInit Python project. The downstream file now says it runs no Python step of its own, because all Python goes through the hub validator's `python-directories` input. The disposition itself still holds, since the override remains for Pester and the shell harnesses. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes have no unresolved findings and the supplied assessments unanimously support approval.
No open issues 🎉
What changed in this PR
Promotes develop to main, correcting governance wording and updating HomeAutomation-Config’s registry and pre-commit rollout metadata.
Changes:
- Rewords forbidden VS Code filenames to avoid false
dead-pathfindings. - Declares HomeAutomation-Config’s Python type, eight directories, and
CODECOV_TOKEN. - Synchronizes the pre-commit hooks rollout tracker.
| File | Description |
|---|---|
registry/repos.json |
Adds HomeAutomation-Config’s Python metadata, directories, secret, and decision record. |
GOVERNANCE.md |
Names forbidden VS Code files by basename under .vscode/. |
docs/pre-commit-hooks-rollout.md |
Aligns rollout status and registry types for ProjectTemplate and HomeAutomation-Config. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3535 +/- ##
=======================================
Coverage 81.58% 81.58%
=======================================
Files 26 26
Lines 8972 8972
=======================================
Hits 7320 7320
Misses 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
developtomain:GOVERNANCE.md"Editor and Tasks" names the forbidden VS Code files by basename under.vscode/. A carrier that once deleted.vscode/settings.jsoncan then re-vendor the section without the prose gate'sdead-pathrule refusing it. This fixes the defect GOVERNANCE.md Editor and Tasks Names .vscode/settings.json to Forbid It, Which Every Carrier That Ever Deleted That File Reads as a Dead Path #1612 describes (that issue is closed and is referenced here, not closed by this PR).python, its eightpythonDirectories, andCODECOV_TOKEN, with a driftNote recording the maintainer's decision. The pre-commit hooks rollout tracker rows are updated to match.Closes #2255
🤖 Generated with Claude Code