Skip to content

Make the Model Tiers Bullets Agree on What a Dispatch Naming No Model Runs At - #3538

Merged
ptr727 merged 2 commits into
developfrom
feature/3529-model-tiers-no-model
Oct 27, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/3529-model-tiers-no-model

Conversation

@ptr727

@ptr727 ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

AGENTS.md "Model Tiers" gave two answers for a dispatch that names no model. The highest bullet states the conditional form: the agent definition's model where one is set, otherwise the session's own. Two later bullets stated only the session fallback.

  • The "A tier resolves only through this table" bullet loses its trailing clause. It now says only that such a session names no model.
  • The "An orchestrating seat" bullet loses its restating sentence. Its rationale, "a choice nobody made", is false where an agent definition pins a model.

The highest bullet stays the single statement of the result. scripts/build_dist.py regenerated the include regions in backlog-burndown, local-strict-review, and unattended-handoff, plus their generated copies.

Pre-existing findings, filed

Closes on promotion: #3529

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 27, 2026 15:59
The highest bullet says a dispatch naming no model runs at its agent
definition's model where one is set, and otherwise at the session's own.
Two later bullets stated the session fallback without that condition.
Delete the unconditional clause from the table-visibility bullet, and
point the orchestrating-seat bullet at the highest bullet's statement.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its rationale, "a choice nobody made", is false where an agent definition
pins a model. The bullet's heading already states the rule, so the
sentence goes rather than being qualified.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 27, 2026 23:02
@ptr727

ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 4d76796a456d4cc41330331628b6c9403a704360, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are documentation updates with no unresolved review findings.

No open issues 🎉

What changed in this PR

This documentation-only pull request removes contradictory model fallback wording from the canonical Model Tiers guidance and regenerates the affected skill distributions and source digests.

Changes:

  • Removes the conflicting session-model fallback wording from AGENTS.md.
  • Regenerates the authored, GitHub, and Claude skill copies.
  • Updates the corresponding source-digest files.
File Description
AGENTS.md Updates the canonical Model Tiers guidance.
.github/​skills/​unattended-handoff/​SKILL.md Regenerated GitHub skill copy.
.github/​skills/​local-strict-review/​SKILL.md Regenerated GitHub skill copy.
.github/​skills/​backlog-burndown/​SKILL.md Regenerated GitHub skill copy.
.claude-plugin/​fleet-skills/​skills/​unattended-handoff/​SKILL.md Regenerated Claude skill copy.
.claude-plugin/​fleet-skills/​skills/​local-strict-review/​SKILL.md Regenerated Claude skill copy.
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md Regenerated Claude skill copy.
.claude-plugin/​fleet-skills/​.source-digests/​unattended-handoff Updated source digest.
.claude-plugin/​fleet-skills/​.source-digests/​local-strict-review Updated source digest.
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown Updated source digest.
.agents/​skills/​unattended-handoff/​SKILL.md Updated authored skill include.
.agents/​skills/​local-strict-review/​SKILL.md Updated authored skill include.
.agents/​skills/​backlog-burndown/​SKILL.md Updated authored skill include.

Review effort: Lite

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.58%. Comparing base (d74cf30) to head (4d76796).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3538   +/-   ##
========================================
  Coverage    81.58%   81.58%           
========================================
  Files           26       26           
  Lines         8972     8972           
========================================
  Hits          7320     7320           
  Misses        1652     1652           
Flag Coverage Δ
python-3.13 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 6822697 into develop Oct 27, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3529-model-tiers-no-model branch October 28, 2026 00:15
ptr727 added a commit that referenced this pull request Oct 28, 2026
…y Tests, and Copilot Transient Fixes (#3544)

## Summary

Promotes `develop` to `main`, carrying round 1 of the resync-issue
burndown:

- #3538: `AGENTS.md` "Model Tiers" now states the no-model dispatch
result once, conditionally, in the `highest` bullet. The two bullets
that contradicted it lost their unconditional claims. The three skills
including the section are regenerated.
- #3539: `GOVERNANCE.md` "Durable Knowledge and Self-Improvement"
describes the standing-issue handoff lifecycle, matching `AGENTS.md`
"Session Scope". `agent-conduct` is regenerated.
- #3540: `spec/files.json` gains a `repoOwnedTrees` list declaring
`tests`, and `spec/audit.py` `hub_only_paths` leaves those paths out. A
carrier's own `tests/` file is no longer reported as hub-only.
`spec/validate.py` shape-checks the list, and `AUDIT.md`, `RESYNC.md`
and the project-types assertion state the exclusion.
- #3542: `pr_review.py wait` and `status` read the Copilot run log
before calling an error refusal quota. A `too many files changed` line
is transient and earns one re-request, as `COPILOT_ERROR_TRANSIENT` on
the existing exit 41.
- #3545: promotion fix for Copilot's finding on this pull request.
`spec/validate.py` refuses a `repoOwnedTrees` source that overlaps a
carried `trees[].source` or holds a `baseline` path.

Fixes #3529
Fixes #3504
Fixes #3528
Fixes #3510

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants