Repository navigation
Restore Subjects and Qualifier Scope Lost in the Handoff Skills' Sentence Splits - #3573
Conversation
…ence Splits The #3570 sentence-length sweep split several sentences in unattended-handoff, backlog-burndown and session-handoff in a way that dropped a subject, detached a pronoun from its antecedent, or left a condition or reason on only one half of the split. Restore each original meaning, keeping every sentence at 25 words or fewer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Answer the local review pass: tie the truncation rule back to the full-page check it defines, keep the dead-worker reason over both dispositions, and keep the unlisted-fork scope over the `new --create-label` clause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The re-read applies only where a read returns as many rows as its limit, as the original sentence said. Also bring the dead-worker sentence to 25 plain words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
The affected canonical skills were repaired, both generated distributions were regenerated, and the corresponding source digests were refreshed, leaving only a minor non-blocking grammar nit.
No open issues 🎉
What changed in this PR
This pull request restores subjects, antecedents, and conditional scope lost when the handoff skills were split into shorter sentences. It updates the canonical skill sources, generated distributions, and source digests.
Changes:
- Repairs sentence scope and grammatical references in
unattended-handoff,session-handoff, andbacklog-burndown. - Regenerates the GitHub Copilot and Claude Code skill distributions.
- Refreshes the three corresponding source digests.
- A minor grammar nit remains in the canonical
session-handoffsource regarding the missing-label condition.
| File | Description |
|---|---|
.github/skills/unattended-handoff/SKILL.md |
Generated GitHub Copilot distribution of the repaired skill. |
.github/skills/session-handoff/SKILL.md |
Generated GitHub Copilot distribution of the repaired skill. |
.github/skills/backlog-burndown/SKILL.md |
Generated GitHub Copilot distribution of the repaired skill. |
.claude-plugin/fleet-skills/skills/unattended-handoff/SKILL.md |
Generated Claude Code distribution of the repaired skill. |
.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md |
Generated Claude Code distribution of the repaired skill. |
.claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md |
Generated Claude Code distribution of the repaired skill. |
.claude-plugin/fleet-skills/.source-digests/unattended-handoff |
Updated source digest for the generated skill. |
.claude-plugin/fleet-skills/.source-digests/session-handoff |
Updated source digest for the generated skill. |
.claude-plugin/fleet-skills/.source-digests/backlog-burndown |
Updated source digest for the generated skill. |
.agents/skills/unattended-handoff/SKILL.md |
Canonical repairs to picker, worker, parking, and decision-following instructions. |
.agents/skills/session-handoff/SKILL.md |
Canonical repairs to lane handoff, session closing, and chain instructions; includes the remaining missing-label grammar nit. |
.agents/skills/backlog-burndown/SKILL.md |
Canonical repairs to worktree disposition and promotion-body instructions. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3573 +/- ##
========================================
Coverage 81.60% 81.60%
========================================
Files 26 26
Lines 9070 9070
========================================
Hits 7402 7402
Misses 1668 1668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…tence Length, Handoff Skills, and Blog host-secrets (#3572) ## Summary Promotes `develop` to `main`, carrying round 4 of the resync-issue burndown: - #3569: the registry declares no `python` profile. The schema and `spec/validate.py` refuse one, since each declared directory's `pyproject.toml` shape states its profile. - #3567: the `CODESTYLE.md` Python summary names the undeclared-root default. `CODESTYLE.md`, python-codestyle, and shell-codestyle reach 25 words or fewer per sentence. - #3568: the `pr_review.py` `refusal=` usage text names the `sent` and `spent` readings. pr-review-conduct, drive-pr, `docs/pr-reviewer-reference.md`, and the last Copilot-instructions sentence reach the cap. - #3570: backlog-burndown, session-handoff, and unattended-handoff reach the cap. - #3534: Blog declares the `host-secrets` overlay, and the conformance matrix names it the first adopter. The hub session took this over from the Blog session. - #3573: promotion fix for Copilot's finding on this pull request. It restores the full-page check sentence and repairs 11 more #3570 splits that lost a subject, antecedent, or condition scope. - #3574: promotion fix auditing the #3567 and #3568 splits the same way. It repairs 16 that lost an antecedent, a reason, or a condition's reach. #3567, #3568, and #3570 merged into `develop` on attested local passes, after Copilot refusals read as possible quota. The maintainer authorized each, as recorded on those pull requests. The sweep slices continue #3531 and do not close it. Fixes #3556 Fixes #3563 Fixes #3560 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #3531
This is a promotion fix for review thread
PRRT_kwDOQ5caqM6xQ88won #3572. That thread is the P1 onunattended-handoffpicker step 1, where the full-page check no longer said which reads it applies to.The #3570 sentence-length sweep split sentences in
unattended-handoff,backlog-burndown, andsession-handoff. I compared each split ingit show 8d390acfwith its original. This change repairs each one that was ungrammatical or had lost its subject, an antecedent, or the scope of a qualifier or reason. Each repaired sentence keeps the original meaning and is 25 words or fewer. Text #3570 did not change is left alone, apart from line rewrapping.Splits repaired
unattended-handoff:decisionread are the subject again. The bold term is kept, so step 1's other references still resolve. The check is defined, and the re-read applies only where a read returns a full page.canonical-sweepaside. It is joined back to the label clause, and the aside now namescanonical-sweeprather than "the last".merge-and-releaseis back under "where the round is not narrowed".backlog-burndown:session-handoff:newclause had lost the condition. The scope is unlisted forks again, and the read clause and thenewclause are one sentence again, as in the original.Local review
local-strict-reviewran three recorded passes at thefrontiertier. The first raised 4 findings and the second raised 1, all fixed in the two edit rounds. The third raised 1, recorded below.Open
introducedfindings.agents/skills/unattended-handoff/SKILL.mdworker step 1, classintroduced. The rejoined sentence reads "since it unblocked the lane" where the original read "since it is what unblocked the lane". The meaning is identical, and the reviewer confirmed that. Bring the Handoff Skills' Sentences to 25 Words or Fewer #3570 split this sentence, so its second half is Bring the Handoff Skills' Sentences to 25 Words or Fewer #3570's text. Rejoining it at the original wording runs to 27 words. The reviewer's alternative, "Follow that answer, since...", would restore the split and leave "Follow" outside the condition, which is the scope gap this repair closes. Disposition: declined on that evidence.Dropped findings
.agents/skills/session-handoff/SKILL.md"Running the Chain", unlisted-fork paragraph, classstyle. Copilot's round on0b58dfedraised no thread, but its overview mentions "a minor non-blocking grammar nit ... regarding the missing-label condition". The nearest candidate is the participle "Missing the label there, a read prints...". That phrase is identical ingit show 8d390acf^:.agents/skills/session-handoff/SKILL.mdline 359. Neither Bring the Handoff Skills' Sentences to 25 Words or Fewer #3570 nor this change altered it beyond rewrapping, so it is out of this change's scope.🤖 Generated with Claude Code