Skip to content

Sync the view dropdown when Top tier sort forces card view #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptrlrd wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Sync the view dropdown when Top tier sort forces card view #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/app/cards/CardsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,12 @@ function CardsClientInner({ initialCards }: { initialCards: Card[] }) {
resultCount={sortedCards.length}
sortOptions={sortOptions}
sortValue={sort}
onSortChange={(v) => setFilterAndUrl("sort", v, setSort)}
onSortChange={(v) => {
setFilterAndUrl("sort", v, setSort);
// Score sort is designed around the full card renders; switch the
// view WITH the dropdown instead of silently overriding it below.
if (v === "score" && view !== "card") pickView("card");
}}
filters={[
{
label: "View",
Expand Down Expand Up @@ -265,8 +270,7 @@ function CardsClientInner({ initialCards }: { initialCards: Card[] }) {
]}
/>

{view === "card" || sort === "score" ? (
// Score sort always uses the card view and shows WR / picks per card.
{view === "card" ? (
// Sit the transparent card renders on a subtle panel so the grid reads
// as a contained module instead of floating on the page background.
<div className="rounded-2xl border border-[var(--border-subtle)] bg-[var(--bg-card)]/40 p-3 sm:p-5">
Expand Down
Loading