Skip to content

Filter placeholders read "Any" instead of "All" #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptrlrd merged 1 commit into from
Jul 31, 2026
Merged

Filter placeholders read "Any" instead of "All" #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/app/cards/CardsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,31 +233,31 @@ function CardsClientInner({ initialCards }: { initialCards: Card[] }) {
noEmptyOption: true,
},
{
label: "All Colors",
label: "Any Color",
value: color,
options: colorOptions,
onChange: (v) => setFilterAndUrl("color", v, setColor),
},
{
label: "All Types",
label: "Any Type",
value: type,
options: typeOptions,
onChange: (v) => setFilterAndUrl("type", v, setType),
},
{
label: "All Rarities",
label: "Any Rarity",
value: rarity,
options: rarityOptions,
onChange: (v) => setFilterAndUrl("rarity", v, setRarity),
},
{
label: "All Costs",
label: "Any Cost",
value: cost,
options: costOptions,
onChange: (v) => setFilterAndUrl("cost", v, setCost),
},
{
label: "All Keywords",
label: "Any Keyword",
value: keyword,
options: keywordOptions,
onChange: (v) => setFilterAndUrl("keyword", v, setKeyword),
Expand Down
8 changes: 4 additions & 4 deletions frontend/app/cards/browse/[slug]/BrowseDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,31 +102,31 @@ export default function BrowseDetail({ initialCards, fixedParams }: BrowseDetail
const filters = [];
if (showColorFilter) {
filters.push({
label: "All Colors",
label: "Any Color",
value: color,
options: colorOptions,
onChange: setColor,
});
}
if (showTypeFilter) {
filters.push({
label: "All Types",
label: "Any Type",
value: type,
options: typeOptions,
onChange: setType,
});
}
if (showRarityFilter) {
filters.push({
label: "All Rarities",
label: "Any Rarity",
value: rarity,
options: rarityOptions,
onChange: setRarity,
});
}
if (showKeywordFilter) {
filters.push({
label: "All Keywords",
label: "Any Keyword",
value: keyword,
options: keywordOptions,
onChange: setKeyword,
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/enchantments/EnchantmentsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function EnchantmentsClientInner({ initialEnchantments }: { initialEnchantments:
resultCount={enchantments.length}
filters={[
{
label: "All Card Types",
label: "Any Card Type",
value: cardType,
options: cardTypeOptions,
onChange: (v) => setFilterAndUrl("cardType", v, setCardType),
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/encounters/EncountersClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ function EncountersClientInner({ initialEncounters }: { initialEncounters: Encou
resultCount={filtered.length}
filters={[
{
label: "All Types",
label: "Any Type",
value: roomType,
options: roomTypeOptions,
onChange: (v) => setFilterAndUrl("roomType", v, setRoomType),
},
{
label: "All Acts",
label: "Any Act",
value: act,
options: actOptions,
onChange: (v) => setFilterAndUrl("act", v, setAct),
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/events/EventsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,13 @@ function EventsClientInner({ initialEvents }: { initialEvents: GameEvent[] }) {
resultCount={events.length}
filters={[
{
label: "All Types",
label: "Any Type",
value: type,
options: typeOptions,
onChange: (v) => setFilterAndUrl("type", v, setType),
},
{
label: "All Acts",
label: "Any Act",
value: act,
options: actOptions,
onChange: (v) => setFilterAndUrl("act", v, setAct),
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/guides/GuidesClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,13 @@ function GuidesClientInner({ initialGuides }: { initialGuides: GuideSummary[] })
onSortChange={(v) => setFilterAndUrl("sort", v, setSort)}
filters={[
{
label: "All Categories",
label: "Any Category",
value: category,
options: categoryOptions,
onChange: (v) => setFilterAndUrl("category", v, setCategory),
},
{
label: "All Difficulties",
label: "Any Difficulty",
value: difficulty,
options: difficultyOptions,
onChange: (v) => setFilterAndUrl("difficulty", v, setDifficulty),
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/keywords/[id]/KeywordDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export default function KeywordDetail({ initialResult }: { initialResult?: Initi
resultCount={filtered.length}
filters={[
{
label: "All Characters",
label: "Any Character",
value: color,
options: colorOptions,
onChange: setColor,
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/monsters/MonstersClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ function MonstersClientInner({ initialMonsters }: { initialMonsters: Monster[] }
resultCount={filtered.length}
filters={[
{
label: "All Types",
label: "Any Type",
value: type,
options: typeOptions,
onChange: (v) => setFilterAndUrl("type", v, setType),
},
{
label: "All Acts",
label: "Any Act",
value: act,
options: actOptions,
onChange: (v) => setFilterAndUrl("act", v, setAct),
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/potions/PotionsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ function PotionsClientInner({ initialPotions }: { initialPotions: Potion[] }) {
onSortChange={(v) => setFilterAndUrl("sort", v, setSort)}
filters={[
{
label: "All Rarities",
label: "Any Rarity",
value: rarity,
options: rarityOptions,
onChange: (v) => setFilterAndUrl("rarity", v, setRarity),
},
{
label: "All Characters",
label: "Any Character",
value: pool,
options: poolOptions,
onChange: (v) => setFilterAndUrl("pool", v, setPool),
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/powers/PowersClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,13 @@ const [powers, setPowers] = useState<Power[]>(initialPowers);
resultCount={merged.length}
filters={[
{
label: "All Types",
label: "Any Type",
value: type,
options: typeOptions,
onChange: setType,
},
{
label: "All Stack Types",
label: "Any Stack Type",
value: stackType,
options: stackOptions,
onChange: setStackType,
Expand Down
6 changes: 3 additions & 3 deletions frontend/app/relics/RelicsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,19 +163,19 @@ function RelicsClientInner({ initialRelics }: { initialRelics: Relic[] }) {
onSortChange={(v) => setFilterAndUrl("sort", v, setSort)}
filters={[
{
label: "All Rarities",
label: "Any Rarity",
value: rarity,
options: rarityOptions,
onChange: (v) => setFilterAndUrl("rarity", v, setRarity),
},
{
label: "All Pools",
label: "Any Pool",
value: pool,
options: poolOptions,
onChange: (v) => setFilterAndUrl("pool", v, setPool),
},
{
label: "All Ancients",
label: "Any Ancient",
value: ancient,
options: ancientOptions,
onChange: (v) => setFilterAndUrl("ancient", v, setAncient),
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/timeline/TimelineClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export default function TimelineClient({
resultCount={epochs.length}
filters={[
{
label: "All Stories",
label: "Any Story",
value: storyFilter,
options: storyOptions,
onChange: setStoryFilter,
Expand Down
Loading
Loading