Skip to content

Section submenu reads as a table of contents, not tabs #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptrlrd merged 1 commit into from
Jul 31, 2026
Merged

Section submenu reads as a table of contents, not tabs #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/app/achievements/[id]/AchievementDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export default function AchievementDetail({ initialAchievement }: { initialAchie

{/* Sticky ToC */}
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/acts/[id]/ActDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export default function ActDetail({ initialAct }: { initialAct?: Act | null } =

{/* Sticky ToC */}
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/ascensions/[id]/AscensionDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export default function AscensionDetail({ initialAscension }: { initialAscension

{/* Sticky ToC */}
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/badges/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export default async function BadgePage({ params }: Props) {
{/* Table of contents (static: server-rendered page) */}
{badge.tiered && (
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
<a href="#description">Description</a>
<a href="#tiers">Tiers</a>
</nav>
Expand Down
16 changes: 11 additions & 5 deletions frontend/app/card-revamp.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,20 @@
.card-rvmp .entity-lead p { margin: 0 0 10px; }
.card-rvmp .entity-lead p:last-child { margin-bottom: 0; }

/* ── sticky ToC ── */
/* ── sticky ToC ──
Styled as a labeled table of contents (plain anchor links, underlined when
active) rather than tab pills: clicking one only scrolls, and the old tab
look promised a view switch it never delivered. */
.card-rvmp .toc { position: sticky; top: 64px; z-index: 20; margin: 28px 0 0; padding: 10px 0;
background: color-mix(in srgb, var(--bg) 90%, transparent); backdrop-filter: blur(6px);
border-top: 1px solid var(--border); border-bottom: 1px solid var(--border);
display: flex; gap: 4px; flex-wrap: wrap; }
.card-rvmp .toc a { color: var(--text-2); font-size: 13px; padding: 5px 11px; border-radius: 4px; }
.card-rvmp .toc a:hover { color: var(--text); background: var(--surface); }
.card-rvmp .toc a.on { color: var(--spine); background: var(--spine-soft); }
display: flex; gap: 4px 16px; flex-wrap: wrap; align-items: baseline; }
.card-rvmp .toc-label { font-family: var(--mono); font-size: 11px; letter-spacing: .07em;
text-transform: uppercase; color: var(--text-3); }
.card-rvmp .toc a { color: var(--text-2); font-size: 13px; padding: 2px 0; }
.card-rvmp .toc a:hover { color: var(--text); text-decoration: underline; text-underline-offset: 5px; }
.card-rvmp .toc a.on { color: var(--spine); text-decoration: underline; text-underline-offset: 5px;
text-decoration-thickness: 2px; }

/* ── sections ── */
.card-rvmp section { padding-top: 40px; scroll-margin-top: 128px; }
Expand Down
1 change: 1 addition & 0 deletions frontend/app/cards/[id]/CardDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ export default function CardDetail({ initialCard, initialEnchantments, initialSt

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/characters/[id]/CharacterDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ export default function CharacterDetail({ initialCharacter }: { initialCharacter

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/enchantments/[id]/EnchantmentDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export default function EnchantmentDetail({

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/encounters/[id]/EncounterDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export default function EncounterDetail({ initialEncounter, encounterStat }: { i

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/events/[id]/EventDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export default function EventDetail({

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/merchant/MerchantToc.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export default function MerchantToc({ items }: { items: { id: string; label: str

return (
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
{items.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/monsters/[id]/MonsterDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ export default function MonsterDetail({

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/potions/[id]/PotionDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ export default function PotionDetail({

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/powers/[id]/PowerDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export default function PowerDetail({ initialPower }: { initialPower?: Power | n

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/relics/[id]/RelicDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ export default function RelicDetail({

{/* Sticky ToC */}
<nav className="toc" aria-label={t("On this page", lang)}>
<span className="toc-label">{t("On this page", lang)}</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
1 change: 1 addition & 0 deletions frontend/app/timeline/[id]/EpochDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ export default function EpochDetail({ initialEpoch }: { initialEpoch?: Epoch | n
{/* Sticky ToC */}
{tocItems.length > 0 && (
<nav className="toc" aria-label="On this page">
<span className="toc-label">On this page</span>
{tocItems.map((it) => (
<a
key={it.id}
Expand Down
Loading