Skip to content

Fixed validation job not to fail when there is nothing to check #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcin-cebo wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fixed validation job not to fail when there is nothing to check #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-validations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Run PHPStan
run: vendor/bin/phpstan analyze --memory-limit 256M
- name: Run phpcs on changed files
run: git diff --name-only --diff-filter=d origin/master HEAD | grep -E '\.php$' | xargs vendor/bin/phpcs --standard=PSR12
run: git diff --name-only --diff-filter=d origin/master HEAD | { grep -E '\.php$' || true; } | xargs --no-run-if-empty vendor/bin/phpcs --standard=PSR12
- name: Cancel workflow runs for commit on error
if: failure()
uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
Expand Down
Loading