Deduplicate channels and groups in request building#173
Merged
Conversation
Add `.uniq` calls when building the URL path and channel-group query parameter to prevent duplicate channels and channel groups from leaking into HTTP requests. feat(heartbeat): deduplicate channels and groups in request building Add `.uniq` calls when building the URL path and channel-group query parameter to prevent duplicate channels and channel groups from leaking into HTTP requests.
parfeon
added
status: done
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Update recorded URIs in presence cassettes to reflect that duplicate channels are now removed before building the request URL.
jguz-pubnub
approved these changes
Mar 3, 2026
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(subscribe): deduplicate channels and groups in request building
Add
.uniqcalls when building the URL path and channel-group query parameter to prevent duplicate channels and channel groups from leaking into HTTP requests.refactor(heartbeat): deduplicate channels and groups in request building
Add
.uniqcalls when building the URL path and channel-group query parameter to prevent duplicate channels and channel groups from leaking into HTTP requests.