-
Notifications
You must be signed in to change notification settings - Fork 61
hw: Add Reduction Feature #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
04ef3cc
hw: Improve VC parametrization
Lore0599 ef9073b
hw: Introduce support for reduction operations
6398a5e
hw: Align reduction to VC support
Lore0599 6f6564c
hw: Remove complex reduction modules
Lore0599 bb8ca1c
Initial RTL clenaing
Lore0599 8a21896
Remove unused cfg parameters
Lore0599 b80869b
Remove RdLoopBack: now coll only with loopback in the NoC
Lore0599 7b61924
hw: Add support for reduction interface
Lore0599 1e52969
Fix bender yml
Lore0599 7cb41e1
pr: Initial round of review
Lore0599 acc0fa5
Fix hdr in tb mcast
Lore0599 8aeeed3
floogen: Generate new collective cfg struct
Lore0599 c655345
hw: Merge reduction types into floonoc types
Lore0599 e7e51ac
lint: Initial linting clean
Lore0599 4a0f564
fllogen: Extend to support generic collective types
Lore0599 62d552d
floogen: Fix extra user field in collect user
Lore0599 437f44c
floogen: Improve VC warning
Lore0599 2947337
floogen: Merge reduction pipeline cfg into general cfg
Lore0599 f735715
hw; Refactor reduction opcode name
Lore0599 42c668d
synth: Fix synth wrapper to new module interfaces
Lore0599 45b29bf
ci: Fix linting
Lore0599 d663c76
Bump PD
Lore0599 4c98673
floogen: Implement PR suggestions
Lore0599 bb213d0
deps: Revert axi fork
fischeti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # Copyright 2025 ETH Zurich and University of Bologna. | ||
| # Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Example: full collective support | ||
| # - narrow + wide multicast | ||
| # - barrier (LSB-AND) | ||
| # - narrow reduction: all integer ops (Add, Mul, MinS, MinU, MaxS, MaxU) | ||
| # - wide reduction: only Add and Max (selective ops example) | ||
|
|
||
| name: nw_mesh_collective | ||
| description: "4x4 NW mesh with full collective operation support" | ||
| network_type: "narrow-wide" | ||
|
|
||
| routing: | ||
| route_algo: "XY" | ||
| use_id_table: true | ||
| collective: | ||
| en_narrow_multicast: true | ||
| en_wide_multicast: true | ||
| en_barrier: true | ||
| en_narrow_reduction: | ||
| rd_pipeline_depth: 1 # all integer ops, custom hw config | ||
| en_wide_reduction: # selective FP ops, default hw config | ||
| ops: [Add, Max] | ||
| rd_pipeline_depth: 5 | ||
| cut_offload_intf: true | ||
| # decouple_rw: Phys | ||
| vc_impl: preempt | ||
|
|
||
| protocols: | ||
| - name: "narrow_in" | ||
| type: "narrow" | ||
| protocol: "AXI4" | ||
| data_width: 64 | ||
| addr_width: 48 | ||
| id_width: 5 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| user: 5 | ||
| - name: "narrow_out" | ||
| type: "narrow" | ||
| protocol: "AXI4" | ||
| data_width: 64 | ||
| addr_width: 48 | ||
| id_width: 2 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| user: 5 | ||
| - name: "wide_in" | ||
| type: "wide" | ||
| protocol: "AXI4" | ||
| data_width: 512 | ||
| addr_width: 48 | ||
| id_width: 3 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| - name: "wide_out" | ||
| type: "wide" | ||
| protocol: "AXI4" | ||
| data_width: 512 | ||
| addr_width: 48 | ||
| id_width: 1 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
|
|
||
| endpoints: | ||
| - name: "cluster" | ||
| array: [4, 4] | ||
| addr_range: | ||
| base: 0x2000_0000 | ||
| size: 0x0004_0000 | ||
| en_collective: true | ||
| mgr_port_protocol: | ||
| - "narrow_in" | ||
| - "wide_in" | ||
| sbr_port_protocol: | ||
| - "narrow_out" | ||
| - "wide_out" | ||
|
|
||
| routers: | ||
| - name: "router" | ||
| array: [4, 4] | ||
| degree: 5 | ||
|
|
||
| connections: | ||
| - src: "cluster" | ||
| dst: "router" | ||
| src_range: | ||
| - [0, 3] | ||
| - [0, 3] | ||
| dst_range: | ||
| - [0, 3] | ||
| - [0, 3] | ||
| dst_dir: "Eject" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| # Copyright 2025 ETH Zurich and University of Bologna. | ||
| # Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Example: narrow + wide multicast only (no reduction, no barrier) | ||
|
|
||
| name: nw_mesh_mcast | ||
| description: "4x4 NW mesh with narrow and wide multicast support" | ||
| network_type: "narrow-wide" | ||
|
|
||
| routing: | ||
| route_algo: "XY" | ||
| use_id_table: true | ||
| collective: | ||
| en_narrow_multicast: true | ||
| en_wide_multicast: true | ||
|
|
||
| protocols: | ||
| - name: "narrow_in" | ||
| type: "narrow" | ||
| protocol: "AXI4" | ||
| data_width: 64 | ||
| addr_width: 48 | ||
| id_width: 5 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| user: 5 | ||
| - name: "narrow_out" | ||
| type: "narrow" | ||
| protocol: "AXI4" | ||
| data_width: 64 | ||
| addr_width: 48 | ||
| id_width: 2 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| user: 5 | ||
| - name: "wide_in" | ||
| type: "wide" | ||
| protocol: "AXI4" | ||
| data_width: 512 | ||
| addr_width: 48 | ||
| id_width: 3 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
| - name: "wide_out" | ||
| type: "wide" | ||
| protocol: "AXI4" | ||
| data_width: 512 | ||
| addr_width: 48 | ||
| id_width: 1 | ||
| user_width: | ||
| collective_mask: 48 | ||
| collective_op: 4 | ||
|
|
||
| endpoints: | ||
| - name: "cluster" | ||
| array: [4, 4] | ||
| addr_range: | ||
| base: 0x2000_0000 | ||
| size: 0x0004_0000 | ||
| en_collective: true | ||
| mgr_port_protocol: | ||
| - "narrow_in" | ||
| - "wide_in" | ||
| sbr_port_protocol: | ||
| - "narrow_out" | ||
| - "wide_out" | ||
|
|
||
| routers: | ||
| - name: "router" | ||
| array: [4, 4] | ||
| degree: 5 | ||
|
|
||
| connections: | ||
| - src: "cluster" | ||
| dst: "router" | ||
| src_range: | ||
| - [0, 3] | ||
| - [0, 3] | ||
| dst_range: | ||
| - [0, 3] | ||
| - [0, 3] | ||
| dst_dir: "Eject" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration for collectives seems quite complicated. Potentially, adding some (AI generated) documentation would be nice, but optional.