Draft
Conversation
Author
micprog
reviewed
May 18, 2024
Member
micprog
left a comment
There was a problem hiding this comment.
It looks like this is still work in progress, so I converted to draft. Feel free to mark as ready for review when ready.
| svm_trans trans; | ||
| mailbox svm_trans gen2drvr_mbx; | ||
|
|
||
| virtual functiona svm_trans gen (); |
Member
There was a problem hiding this comment.
Suggested change
| virtual functiona svm_trans gen (); | |
| virtual function svm_trans gen (); |
| //some useful typedefs | ||
| // | ||
| // | ||
| package svm_pkg; |
Member
There was a problem hiding this comment.
Just out of curiosity, what does SVM stand for?
Comment on lines
+43
to
+49
| //TODO: connect gen2drvr _mbx to generators' gen2drvr_mbx; | ||
| //TODO: replace durif in virtual interface declaration with appropriate | ||
| //interface name | ||
| //TODO:fill in the drive task | ||
| //TODO:define a constructor which should: | ||
| //a) create the mailbox | ||
| //b) provide a name for the driver |
Member
There was a problem hiding this comment.
It looks like there are still a lot of todos
Author
|
Thanks for reviewing it
These base classes are meant as templates over which to build the testbench.
The TODOs are notes to the testbench builder for step they have to do to complete the testbench implementation
SVM stands for systemverilog methodology
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Michael Rogenmoser ***@***.***>
Sent: Saturday, May 18, 2024 4:01:09 AM
To: pulp-platform/common_verification ***@***.***>
Cc: Faisal Haque ***@***.***>; Author ***@***.***>
Subject: Re: [pulp-platform/common_verification] Faisal/svm (PR #7)
@micprog commented on this pull request.
It looks like this is still work in progress, so I converted to draft. Feel free to mark as ready for review when ready.
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
+ virtual task run();
+ virtual task finish();
+ endclass
+ virtual class svm_trans;
+ string name;
+ svm_logger log;
+
+ virtual function svm_trans cp();
+ virtual task pr();
+ virtual function bit compare(svm_trans trans);
+ endclass
+ virtual class svm_generator extends svm_component;
+ svm_trans trans;
+ mailbox svm_trans gen2drvr_mbx;
+
+ virtual functiona svm_trans gen ();
⬇️ Suggested change
- virtual functiona svm_trans gen ();
+ virtual function svm_trans gen ();
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
@@ -0,0 +1,126 @@
+//SVM Base class lib:
+//svm_component
+//svm_trans
+//svm_logger
+//macros if any
+//svm_generator
+//svm_env
+//svm_driver
+//svm_monitor
+//svm_scoreboard
+//svm_test
+//some useful typedefs
+//
+//
+package svm_pkg;
Just out of curiosity, what does SVM stand for?
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
+ //TODO: connect gen2drvr _mbx to generators' gen2drvr_mbx;
+ //TODO: replace durif in virtual interface declaration with appropriate
+ //interface name
+ //TODO:fill in the drive task
+ //TODO:define a constructor which should:
+ //a) create the mailbox
+ //b) provide a name for the driver
It looks like there are still a lot of todos
—
Reply to this email directly, view it on GitHub<#7 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BIPB3SRI4IGFAPASEW2AXK3ZC4YHLAVCNFSM6AAAAABH4TJRYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRUG4ZDIMBZHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This imports the sum_pkg.svh which is a base class library we will use to create test benches
The code is uncompiled so wee will need to compile and fix any compile issues