make tile 0 be the only tile clearing .bss#8
Open
marchioa wants to merge 1 commit intopulp-platform:mainfrom
Open
make tile 0 be the only tile clearing .bss#8marchioa wants to merge 1 commit intopulp-platform:mainfrom
marchioa wants to merge 1 commit intopulp-platform:mainfrom
Conversation
Member
|
This change as-is will trigger some errors in the current test folder (for example, in test_mm_is_2). This is mostly due to the fact that there is no initial barrier in most of the tests, which may result in the core 0 cleaning up one of the static vectors of one of the faster cores. Two possible solutions would be: Option 1 - Modify all tests to have an initial barrier Option 2 - Add a barrier inside the crt0 itself UNFORTUNATELY atm cv32e40p does NOT support the atomic extension, so this mechanism would have to be somehow done without using atomic instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment all tiles clear the
.bsssection incrt0.S. This may cause issues when reading a vector allocated in.bss, since a slower tile might overwrite its contents when starting its routine.This PR solves the issue by having the only tile 0 clearing the
.bss.