chore(runtime): interpreter-throughput benchmark + baseline (measure-first for perf work)#358
Merged
Merged
Conversation
…ure-first for perf work) Makes the tree-walker's throughput a measured number so speed work can be gated (synth discipline: a regression is a number). Self-contained criterion bench (wat-built modules, no filesystem fixture — the old, orphaned kiln-component/benches/execution_benchmarks.rs read a missing test_add.wasm): - compute_loop: arithmetic hot path (dispatch + operand stack + locals) - memory_loop: same loop + i64.store/i64.load per iter (the per-access lock path) Baseline (release, Apple silicon): compute ~14.3 M iter/s (~70 ns/iter); memory ~5.9 M iter/s (~169 ns/iter). The ~99 ns/iter gap for 2 memory ops quantifies the double-mutex memory-access overhead — the optimization signal. Next: a CI regression gate (criterion --save-baseline + compare) and then the memory-access fix, measured against this. Trace: SM-PERF-001
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the interpreter's throughput a measured number so speed work can be gated — the prerequisite for every optimization after it (synth discipline: a regression is a number, not a vibe).
Why
The only execution bench (
kiln-component/benches/execution_benchmarks.rs) was orphaned (not registered as a[[bench]]) and read a missingtest_add.wasmfrom CWD — so perf was entirely unmeasured/ungated.What
Self-contained criterion bench in kiln-runtime (modules built in-process via
wat, no fixture):compute_loop— arithmetic hot path (dispatch + operand stack + locals)memory_loop— same loop +i64.store/i64.loadper iter (the per-access lock path)Baseline (release, Apple silicon)
The ~99 ns/iter gap for two memory ops (only ~6 extra instructions) quantifies the double-mutex memory-access overhead — the optimization signal for the biggest win the assessment found.
Next (gated on this)
--save-baseline+ compare).MemoryAccessorborrow), measured against this baseline.Trace: SM-PERF-001
🤖 Generated with Claude Code