docs(status): advance SQL REQs via dogfooding (229/230 verified, 231 implemented)#587
Merged
Conversation
…ogfood) Flipped via the shipped features themselves: `rivet sql "UPDATE artifacts SET status='implemented' WHERE id IN (...)"` (REQ-230 write path, gluesql engine) for the status advance, then `rivet verify REQ-229/REQ-230` (REQ-226) to advance to verified on their source `// rivet: verifies` markers. REQ-231 stays implemented (no dedicated marker). rivet validate PASS — round-trip fidelity confirmed on real artifacts. Refs: REQ-229, REQ-230, REQ-231, REQ-226 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 84f647d | Previous: 59b99c0 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
37257653 ns/iter (± 2028544) |
25355776 ns/iter (± 602440) |
1.47 |
This comment was automatically generated by workflow using github-action-benchmark.
📐 Rivet artifact delta
Graphgraph LR
REQ_229["REQ-229"]:::modified
REQ_230["REQ-230"]:::modified
REQ_231["REQ-231"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the V on the SQL-interface requirements — using the shipped features on rivet's own artifacts:
rivet sql "UPDATE artifacts SET status='implemented' WHERE id IN ('REQ-229','REQ-230','REQ-231')"— one multi-row write through the REQ-230 write path on the new gluesql engine ("3 artifact(s) updated").rivet verify REQ-229+rivet verify REQ-230(REQ-226) — advanced toverifiedon their// rivet: verifiessource markers.REQ-231 stays
implemented(no dedicated verifies-marker — its verification is "all sql tests pass on gluesql").rivet validatePASS — round-trip fidelity confirmed on real artifacts.A small but real demonstration that the SQL write +
rivet verifyfeatures work end-to-end on the project that built them.🤖 Generated with Claude Code