Fix CalculatekspaceUnfunc with waveforms_and_times

[srapacchi]

Function gradient_waveforms is deprecated.
Note: with this, calculateKspaceUnfunc is still faster than calculateKspacePP

[m-a-x-i-m-z]

I actually always wanted to delete this function, because for any reasonably long sequence, which uses many simple trapezoid gradients and many waiting periods, it is EXTREMELY inefficient and is certainly way slower than calculateKspacePP(). Additionally, it produces k-space on a time-shifted raster, which is also another potential source of problems.

Is there any reasonable use case for this old function?

--M.

[srapacchi]

I understand. There is no absolute need for this function instead of calculateKspacePP. We want to add an optional GIRF convolution within the Pulseq computation of kspace, so I was trying both functions (Unfunc and PP) to compare them and I found this issue. I leave it to you whether this Unfunc function remains or disappears. Thanks!