Repository navigation
release: CHDSharp 1.6.2 - extraction diagnostics - #5
Merged
Merged
Conversation
Extraction writers now log the underlying exception instead of flattening every failure to Chderrwriteerror: data/codec failures map to Chderrdecompressionerror and output I/O to Chderrwriteerror. Read-ahead TryGet/Clear tolerate a semaphore disposed during teardown, and damaged GD-ROM metadata returns Chderrinvaliddata instead of throwing. Adds ExtractionFailureLoggingTests, bumps the version to 1.6.2 and updates the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidDataExceptionmaps toChderrdecompressionerror, and output I/O maps toChderrwriteerror. This fixes the opaquetrack N: Chderrwriteerrorreports.ReadAheadManager.TryGet/Cleartolerate a semaphore disposed during teardown, removing the remainingObjectDisposedExceptionrace.ExtractToDirectoryWithReportingreturnsChderrinvaliddatafor GD-ROM metadata with no readable tracks instead of throwing.ExtractionFailureLoggingTests.WhatsNew.md,docs/ReleaseNotes.md, the READMEs and project banners.Verification
dotnet build -c Release -warnaserror: 0 warnings, 0 errors.CHDSharpTest: 4,219 passed;CHDSharpEncoderTest: 455 passed.chdman0.289.jb inspectcode --severity=WARNING: 0 findings.chdman extractcd.CHDSharp.1.6.2.nupkgsmoke-tested on net8.0/net9.0/net10.0 and published to NuGet.