Allow editing condition on function and data breakpoints

[samisalreadytaken]

No new tests because it's a basic copy-paste job, and it works while connected and disconnected to a server.

[puremourning]

This change is 

[puremourning]

Thanks.

Copy paste or not, it needs tests because I will forget about this functionality and break it.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

[puremourning]

Do We also need to update the docs?

[samisalreadytaken]

You have the comment "Can't find an adapter that supports conditional function breakpoints" in breakpoints.test.vim from 5 years ago. I'll check if they do now when I have time, but what should the approach be if existing test servers still don't support them?

Do We also need to update the docs?

I don't see any mention of breakpoint editing in the docs. But "Supported debugging features - conditional breakpoints (function, line)" line could include "data" as well.

Irrelevant, though, the description of hitCondition is misleading as it is perfectly valid to have condition and hitCondition together.

[puremourning]

The comment is about function breakpoints. Lots of servers support normal conditional breakpoints.

I was assuming that the reason you making this change is for a specific server use case?

[puremourning]

But to answer the question no I still don’t know of any server that supports a condition in a function breakpoint.

[samisalreadytaken]

I use conditional function and data breakpoints with my debugger. If there is no test for function breakpoint conditions (which could already be added but not edited) already, I'm confused as to what exactly I'm supposed to add tests for. Just the window output but not the functionality?

This patch simply adds code path for type == 'F' and type == 'D' for the Edit button (cc) in breakpoints view.