Expose mutable DNSQuery connection settings - #32
Merged
Merged
Conversation
Co-authored-by: purplepixie <1479871+purplepixie@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add getters/setters for DNSQuery object settings
Expose mutable DNSQuery connection settings
Sep 5, 2026
purplepixie
marked this pull request as ready for review
September 5, 2026 22:32
purplepixie
approved these changes
Sep 6, 2026
purplepixie
left a comment
Owner
There was a problem hiding this comment.
Simple getters and setters and tests. Checked functionality and no dangerous changes made by AI. Approved for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNSQuerysettings such as UDP mode were constructor-only, preventing runtime inspection or reconfiguration.