Skip to content

Expose mutable DNSQuery connection settings - #32

Merged
purplepixie merged 2 commits into
masterfrom
copilot/allow-query-object-setting-changes
Sep 6, 2026
Merged

purplepixie merged 2 commits into
masterfrom
copilot/allow-query-object-setting-changes

Conversation

Copilot AI commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

DNSQuery settings such as UDP mode were constructor-only, preventing runtime inspection or reconfiguration.

  • Accessors: Added typed getters and setters for server, port, timeout, UDP mode, debug, and binary debug settings.
  • Coverage: Added focused tests validating default values and runtime updates.
$query = new DNSQuery('dns.example.com');
$query->setUdp(false);

$isTcp = !$query->getUdp();

Co-authored-by: purplepixie <1479871+purplepixie@users.noreply.github.com>
Copilot AI changed the title [WIP] Add getters/setters for DNSQuery object settings Expose mutable DNSQuery connection settings Sep 5, 2026
Copilot AI requested a review from purplepixie September 5, 2026 22:29
@purplepixie
purplepixie marked this pull request as ready for review September 5, 2026 22:32

@purplepixie purplepixie left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple getters and setters and tests. Checked functionality and no dangerous changes made by AI. Approved for merge.

@purplepixie
purplepixie merged commit 51c838f into master Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow changes to Query object settings such as UDP mode

2 participants