Open
Conversation
Member
adeptofvoltron
commented
Mar 27, 2017
adeptofvoltron
commented
added 5 commits
March 27, 2017 13:40
pradzikowski
requested changes
Apr 5, 2017
src/Currency/AbstractCurrency.php
Outdated
|
|
||
| /** | ||
| * AbstractCurrency constructor. | ||
| * @param null $quality |
| { | ||
| if (false === empty($subUnitQuality)) { | ||
| $this->subUnitQuality = $subUnitQuality; | ||
| } elseif (false === empty($quality)) { |
Member
There was a problem hiding this comment.
Strange if-else code block. What if both was not empty ?
Member
Author
There was a problem hiding this comment.
than I throw an exception
adeptofvoltron
commented
Apr 5, 2017
Member
Author
adeptofvoltron
left a comment
adeptofvoltron
left a comment
There was a problem hiding this comment.
@pradzikowski ok. you can check it now
| { | ||
| if (false === empty($subUnitQuality)) { | ||
| $this->subUnitQuality = $subUnitQuality; | ||
| } elseif (false === empty($quality)) { |
Member
Author
There was a problem hiding this comment.
than I throw an exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.