Migrate to valueobjects - #55
Merged
Merged
Conversation
Migrates the value-object feature out of the repository and onto the local Purview.ValueObjects 1.0.0-prerelease.1 package: - EventSourcing core: removes the ValueObjects/ contracts and the Scalar/ValueObject attribute + converter files; references the package; EventStoreSerializationHelpers registers the package's ScalarJsonConverterFactory. - SourceGenerator: removes the value-object generator pipeline and ValueObjectDiagnosticAnalyzer; the aggregate generator now references Purview.ValueObjects.Serialization.ScalarAttribute and emits Purview.ValueObjects.ValueObjectContext with the neutralized Owner/MemberName/Reason members. - Providers, samples, benchmarks, and tests: updated usings and generated shape to the Purview.ValueObjects namespaces. - Adds a local NuGet feed (.local-feed) and pins the package centrally so the solution builds against the local build. Unit tests: 670 pass. Value-object generator/analyzer/code-fix tests now live with the package.
kieronlanning
enabled auto-merge
September 18, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.