fix: prevent archive path traversal (Android & iOS) - #8
Closed
pushpender-singh-ap wants to merge 1 commit into
Closed
fix: prevent archive path traversal (Android & iOS)#8pushpender-singh-ap wants to merge 1 commit into
pushpender-singh-ap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
outputPath.unarchive(archivePath, outputPath)API cannot be abused to overwrite app-writable files outside the intended extraction directory.Description
android/src/main/java/com/unarchive/UnarchiveModule.kt): strengthenisPathAllowedto use canonical path-boundary checks and addisSafeEntryPathentry validation that rejects blank or NUL-containing names, normalizes backslashes, blocks absolute entry names, canonicalizes the destination and enforces the destination is equal to or under the temporary extraction directory before any filesystem writes.ios/Unarchive.mm): addcanonicalPath:isWithinDirectory:andcanonicalPathForPath:helpers and hardenisOutputPathInSandboxandisSafePathto use canonical path-boundary checks and to reject absolute/unsafe entry names without stripping traversal components.SSZipArchiveextraction by checking entry names in the extraction progress callback and fail the extraction if any entry is unsafe, and use canonical post-extraction checks to detect escaped files.Testing
yarn typecheck(succeeded).yarn lint(succeeded).git diff --check(no whitespace/error issues reported).yarn test --runInBand(failed because the existing Jest suite contains no tests; this is an unrelated repo test-suite state issue).cd example/android && ./gradlew :react-native-unarchive:compileDebugKotlin(blocked in this environment due to Gradle/JDK mismatch:Unsupported class file major version 69).Codex Task