Conversation
added missing should package (as dev-dependencies in package.json and as require in test/index.js)
modified schema.methods.save function to reflect changes in mongoose error object
missing file from previous commit
Lib updates
repackaged as mongoose-slugin and version bumped to 0.1.0 for npm publishing
…dated lodash 3.7.0
Deep paths in slugs
(changes needed to math repository name change)
moved mongoose from dependencies to devDependencies (being a mongoose plugin, mongoose should already be a dependency)
update reference in README
|
Sorry for being out of the net on this one; I didn't see your pull request alert for some reason. Most of your changes are good, but your updates to the name, and github origin aren't appropriate for an attempt to contribute back to the original project. If you want to back those out I'll accept the other changes. |
|
no problem i tried a pull request first, but since you didn't reply (and since i needed the updated plugin for my project) i released a new plugin based on your with my modifications (that's the reason for all project changes: name, repo). maybe i should have done it differently, but i have a slightly limited knowledge of github, so i just made modifications to my clone after the pull request. as of now i'm using my version of the plugin, so for me you can ignore my request |
3 participants
I've updated all dependencies to latest version.
Mongoose update required a small change in schema.methods.save function.
Also i've added a dev-dependencies (should) and the relative require in order to run tests.
(sorry if i made some errors in pull / merge request, this is my first ever)