migrate from github to @octokit/rest - #29
Open
kentcdodds wants to merge 2 commits into
Open
Conversation
added 2 commits
August 22, 2018 10:10
Collaborator
|
I think before we could accept this, we'd have to address #15. Deprecation messages are largely ignoreable, so it's not urgent to address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes in the GitHub editor. I just noticed this message when installing
travis-ci:It looks like the version of the
githubmodule used in this package is quite old, so I'm guessing there will be some differences in functionality, though I haven't tested it.My interest here is simply to help out, but I have no real need of this update. I just figured a PR was a step above a quick "FYI issue." Feel free to do whatever you like with this :)