Repository navigation
test(tests): await ACP property turns without polling - #3989
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I replaced 50 ms polling in the ACP instruction and tool-catalog tests with the client's existing terminal callbacks. Each test installs its waiter before calling
startPromptand matches the callback by session and turn. Both the success and failure path clear the active turn before notifying the test.The same property runs, generated inputs, protocol assertions, and one-second failure bound stay in place. No production code changes. The main instruction property had a 9.19 s historical macOS median, and the ACP tool-catalog property had a 3.77 s median. Hosted CI will show how much of that time was polling.
Verification
Notes
PR #3965's previously validated Electron and SQLite cuts are separate. CI keeps the existing lane count.