Skip to content

test(tests): await ACP property turns without polling - #3989

Merged
Harold Hunt (huntharo) merged 2 commits into
mainfrom
codex/prune-acp-property-polling
Nov 19, 2026
Merged

Harold Hunt (huntharo) merged 2 commits into
mainfrom
codex/prune-acp-property-polling

Conversation

@huntharo

Copy link
Copy Markdown
Contributor

Summary

I replaced 50 ms polling in the ACP instruction and tool-catalog tests with the client's existing terminal callbacks. Each test installs its waiter before calling startPrompt and matches the callback by session and turn. Both the success and failure path clear the active turn before notifying the test.

The same property runs, generated inputs, protocol assertions, and one-second failure bound stay in place. No production code changes. The main instruction property had a 9.19 s historical macOS median, and the ACP tool-catalog property had a 3.77 s median. Hosted CI will show how much of that time was polling.

Verification

  • I ran Oxlint, typed lint, dependency boundaries, and git diff --check.
  • I requested full hosted CI for macOS, Windows, and Linux coverage.

Notes

PR #3965's previously validated Electron and SQLite cuts are separate. CI keeps the existing lane count.

@huntharo Harold Hunt (huntharo) added the ci:full Run macOS unit/E2E and Windows E2E on this PR (Re-run all jobs after adding) label Nov 19, 2026
@huntharo
Harold Hunt (huntharo) merged commit 73861b7 into main Nov 19, 2026
39 checks passed
@huntharo
Harold Hunt (huntharo) deleted the codex/prune-acp-property-polling branch November 19, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run macOS unit/E2E and Windows E2E on this PR (Re-run all jobs after adding)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant