Repository navigation
fix(core): credit the clone accounting to its author - #16
Merged
Merged
Conversation
The APFS clone accounting in sharing.rs is Harold Hunt's own work: he wrote it for diskhound in huntharo/diskhound#4 (contributed upstream as tzarebczan/diskhound#40) and ported it to disktree in huntharo#3. When the port came to PwrDisk in #9, the agent that prepared it attached diskhound's MIT notice to it, naming the diskhound project's copyright holder, although no code from that project was copied. Remove that notice and say where the code came from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects how PwrDisk credits its APFS clone accounting (
crates/disktree-core/src/sharing.rs).What happened
I (Harold Hunt) wrote the clone accounting myself, first for diskhound and then for disktree:
maininto the branch.When #9 was prepared, the agent doing the port made a mistake in attribution. It added
licenses/diskhound-MIT.txt, a copy of diskhound's MIT notice naming diskhound's author, and pointedsharing.rsat it. No code from the diskhound project itself was copied into PwrDisk, so that notice credits the wrong person.Changes
licenses/diskhound-MIT.txt.sharing.rsheader now names its author and links the PRs above.Nothing else changes. The code is still MIT-licensed under PwrDisk's own
LICENSE.With thanks to Thomas Zarebczan, who reviewed and merged the diskhound version. This change only corrects whose work this file is.
Testing
cargo xtask lintandcargo xtask testpass on macOS (372 tests).