Skip to content

fix(core): credit the clone accounting to its author - #16

Merged
Harold Hunt (huntharo) merged 1 commit into
mainfrom
fix/clone-accounting-attribution
Oct 30, 2026
Merged

Harold Hunt (huntharo) merged 1 commit into
mainfrom
fix/clone-accounting-attribution

Conversation

@huntharo

Copy link
Copy Markdown

Corrects how PwrDisk credits its APFS clone accounting (crates/disktree-core/src/sharing.rs).

What happened
I (Harold Hunt) wrote the clone accounting myself, first for diskhound and then for disktree:

When #9 was prepared, the agent doing the port made a mistake in attribution. It added licenses/diskhound-MIT.txt, a copy of diskhound's MIT notice naming diskhound's author, and pointed sharing.rs at it. No code from the diskhound project itself was copied into PwrDisk, so that notice credits the wrong person.

Changes

  • Removes licenses/diskhound-MIT.txt.
  • The sharing.rs header now names its author and links the PRs above.

Nothing else changes. The code is still MIT-licensed under PwrDisk's own LICENSE.

With thanks to Thomas Zarebczan, who reviewed and merged the diskhound version. This change only corrects whose work this file is.

Testing
cargo xtask lint and cargo xtask test pass on macOS (372 tests).

The APFS clone accounting in sharing.rs is Harold Hunt's own work: he
wrote it for diskhound in huntharo/diskhound#4 (contributed upstream as
tzarebczan/diskhound#40) and ported it to disktree in
huntharo#3. When the port came to PwrDisk in #9, the agent that
prepared it attached diskhound's MIT notice to it, naming the diskhound
project's copyright holder, although no code from that project was
copied. Remove that notice and say where the code came from.
@huntharo
Harold Hunt (huntharo) merged commit a45bb70 into main Oct 30, 2026
8 checks passed
@huntharo
Harold Hunt (huntharo) deleted the fix/clone-accounting-attribution branch November 9, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant