Repository navigation
feat(release): ship a DMG and Velopack installers with in-app updates - #8
Merged
Merged
Conversation
Harold Hunt (huntharo)
force-pushed
the
ci/signing-environments
branch
from
October 29, 2026 23:11
41be908 to
b2d78ec
Compare
Harold Hunt (huntharo)
force-pushed
the
ci/velopack-dmg
branch
2 times, most recently
from
October 30, 2026 00:04
c2b95df to
32227ac
Compare
Harold Hunt (huntharo)
changed the base branch from
ci/signing-environments
to
main
October 30, 2026 00:04
Harold Hunt (huntharo)
force-pushed
the
ci/velopack-dmg
branch
from
October 30, 2026 00:23
32227ac to
785d583
Compare
This was referenced Oct 30, 2026
Harold Hunt (huntharo)
force-pushed
the
ci/velopack-dmg
branch
from
October 30, 2026 01:23
785d583 to
3851aa7
Compare
Harold Hunt (huntharo)
force-pushed
the
ci/velopack-dmg
branch
from
October 30, 2026 02:03
97d317c to
25bd50d
Compare
Port PwrRoute's release packaging: a universal macOS app packed by vpk and cut into a drag-to-install DMG, Windows x64 and ARM64 Setup.exe, MSI and portable zip, and the Velopack update feeds. Builds run in unprivileged prepare jobs on hosted runners; credentialed sign jobs never check out source and fail without their credentials. The app checks GitHub Releases, downloads in the background and applies on quit or Restart to update; Shift-U opens an Updates panel with the release channel. Releases are cut from CHANGELOG.md sections, starting at 0.12.0.
…perator A bare command path does not expand $arch, so the Windows pack step failed before vpk ran.
Refuse the restart while a removal runs, check again when a channel is picked mid-check, read the Velopack manifest once, and reuse widgets::ago for the last check's age.
Harold Hunt (huntharo)
force-pushed
the
ci/velopack-dmg
branch
from
October 30, 2026 02:47
25bd50d to
bf4a88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings PwrDisk's release packaging up to PwrRoute's: a macOS DMG, Velopack installers and update feeds for Windows x64 and ARM64, and an in-app updater. Targets
main, on top of #2, #3 and #5.Reading the diff: 8,591 of the ~13.8k added lines are
licenses/velopack.txt, generated byscripts/release/velopack-notices.sh(the license notices for the Velopack binariesvpkadds to each install); skip it. The rest is about 5k lines, a third of them ported scripts and workflows.What a release ships now
PwrDisk-<v>-universal.dmg(one app for Apple silicon and Intel, packed byvpk, Developer ID signed, notarized and stapled, DMG too),PwrDisk-osx-Portable.zip, nupkg,releases.osx.jsonfeedPwrDisk-win-Setup.exe,PwrDisk-win.msi(per user),PwrDisk-win-Portable.zip, nupkg,releases.win.jsonwin-arm64: its own Velopack channel and feedinstall.sh, x86_64 and aarch64Everything is signed in jobs that never check out or build source, and a release fails rather than ship unsigned.
Ported from PwrRoute
release.yml's prepare/sign split: unprivilegedmacos-prepare/windows-preparebuild and hand over an archive whose SHA-256 travels as a job output;macos-sign(environmentapple-signing, hosted macos-26) andwindows-sign(environmentwindows-signing) verify both and pack withvpk. Release created at the end from theCHANGELOG.mdsection, as a Pre-release, with every asset and feed. Same environments, secret and variable names as Sign releases through the apple-signing and windows-signing environments #3.preview-build.yml(labelbuild-preview), and.github/workflows/README.mddocumenting the design.scripts/release/:install-vpk.sh(pinned, SHA-512-verified vpk 1.2.161),vpk-pack-windows.ps1,macos-dmg.sh,dmg-layout.py(writes.DS_Storedirectly, no Finder),macos-signing.py(job-scoped keychain with restore-on-cleanup),macos_packaging_test.py,generate-dmg-background.swift,velopack-notices.sh.packaging/dmg/(background redrawn with the PwrDisk wordmark, "disks / space"),packaging/macos/PwrDisk.entitlements(none),licenses/velopack.txt.velopack = "=1.2.161",updater.rs,update_channel.rs(the family's Stable/Beta × Latest/Prerelease slots, with their tests),github_releases.rspointed at pwrdrvr/PwrDisk, Velopack's startup hook first inmain.cargo xtask release-checkandCHANGELOG.md.Adapted
win-arm64). Both architectures build on native runners and are packed and signed by onewindows-signjob. The matrix prepare job emits one digest output per architecture;windows-signrefuses an empty one, and the preview workflow exercises the same hand-off.cargo xtask bundle --universalbuilds both targets and joins them withlipo;--app-onlystops at the app for the sign job. Without itbundlealso makes the DMG through the samemacos-dmg.sh, so CI's macOS job now checks the DMG too.PWRDISK_VERSIONstamps preview versions.AppIcon.icns(drawn from the SVG), not a separate committed.icns.ualready goes up a level) or PwrDisk › Check for Updates… on macOS. It shows the version and whether this copy can update, the four channel slots (arrows + enter or click to pick; saved toupdate-channel.jsonbeside the Power Efficiency preset), the last check's outcome, Check now, and Restart to update/switch once a download is ready. Tokens inui.rs, state instate.rs, a window-harness test (the_updates_panel_picks_a_channel_and_keeps_the_keys) that also checks keys don't leak to the treemap behind it.cx.on_app_quit, so every quit path (menu,q, closing the window) installs a downloaded update; startup never auto-applies, as in PwrRoute, so a package held for a channel the user left is never installed.make installon macOS now uses--app-only.Deliberately left out
--require-icon-catalogflag — the release and preview jobs check the bundle forAssets.carandCFBundleIconNameinstead.typecheck/testrelease jobs (CI layout differs; the release lints once and tests on each platform it builds)..deb— not trivial enough here (nopackage-linuxtask); Linux keeps the tarball. Velopack is not used on Linux (its only Linux output is an AppImage).THIRD_PARTY_LICENSESfor the app's own crates (cargo-about/deny) — PwrDisk didn't have one before; only Velopack's binaries' notices are added. Worth a follow-up.Carried from #3
Built on #3's reviewed release workflow; this keeps its rules in the new jobs: a dispatched run must start from the tag itself (checked in the first job), every action pinned to a commit SHA (including the new
setup-dotnetand everything inpreview-build.yml), the Windows signer compared by its simple name exactly (GetNameInfo(SimpleName) -cne "PwrDrvr LLC"), and no file contents through a PowerShell redirect (the Windows payload is copied from the prepare job's checkout).The branch is
ci/velopack-dmg: the repo already has areleasebranch, sorelease/…cannot exist.Version
0.12.0: the next minor after disktree 0.11.0, the last upstream version the fork took, so versions keep ordering across the fork and nobody mistakes PwrDisk's first release for an upstream patch.CHANGELOG.mdhas its notes.Verification
cargo xtask lintandcargo xtask testgreen locally (macOS), including the new harness test and the Python packaging tests (now part ofcargo xtask teston Unix); actionlint + shellcheck clean.cargo xtask bundle --universallocally: the ad hoc DMG mounts withPwrDisk.app(x86_64 + arm64,codesign --verify --deep --strictOK) and anApplications -> /Applicationslink, plus background,.DS_Storeand volume icon.vpk packcould not run locally (only a .NET preview SDK here), so thebuild-previewrun on this PR proves it on hosted runners, through the same prepare → pack hand-off as the release, minus signing:vpk pack(ad hoc) → DMG; the job mounts the DMG and checksPwrDisk.app(arm64 + x86_64,UpdateMacpresent,codesign --verify --deep --strict), theApplicationslink, background,.DS_Storeand volume icon.PwrDisk-win-Setup.exe,PwrDisk-win.msi,PwrDisk-win-Portable.zip,releases.win.json(x64) andPwrDisk-win-arm64-Setup.exe,PwrDisk-win-arm64.msi,PwrDisk-win-arm64-Portable.zip,releases.win-arm64.json(ARM64), with no file name shared between them; the per-architecture digest outputs of the matrix arrived intact.macos-sign,windows-sign,publish) can only run from av*tag, so it first runs for real on the first release.First release, for you
v0.12.0onmainand push it (the tag must matchCargo.tomlandCHANGELOG.md).apple-signingandwindows-signingdeployments when the run pauses.PwrDisk-win-Setup.exefrom the resulting Pre-release, check them, then promote:gh release edit v0.12.0 -R pwrdrvr/PwrDisk --latest --prerelease=false. Installed copies on the default Stable · Latest channel only see promoted releases.The first release has no delta (nothing to diff against); later ones get one automatically. The repo must stay public for the updater to read releases without a token.
Also fixes main's red CI: #7's
bundle-macos-26job was missing from #12's classifier job list, so Classify Changes failed. It is now gated on the classifier like the other jobs.