Repository navigation
fix(transport): preserve JSON strings across stdio frames - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Node 24.22.1,
node:readlinesplits literal U+2028/U+2029 inside valid JSON strings. The resulting fragments are discarded byJsonRpcConnection, leaving requests to time out.Frame protocol stdout on LF only through a shared
readJsonRpcLinesreader. Preserve split UTF-8 characters, accept CRLF and final EOF tails, and leave process ownership and stderr behavior with callers. Malformed messages now produce content-free diagnostics. Includes a patch changeset.Verification
pnpm build, fullpnpm test,pnpm typecheck,pnpm lint:boundaries,pnpm lint:deps, andpnpm lint:licenses; reran the transport suite and typecheck after final test changes.Notes
This is a backward-compatible patch release for LF/CRLF-delimited JSON-RPC and can ship independently of the PwrAgent caller PR.
The owning source and protocol stdout caller audit are recorded in
docs/stdio-framing.md. No Codex private storage was read, and no shared App Server was stopped or restarted.