Explicitly export types from __init__.py#54
Open
dbarnett wants to merge 1 commit intopy-vobject:masterfrom
Open
Explicitly export types from __init__.py#54dbarnett wants to merge 1 commit intopy-vobject:masterfrom
dbarnett wants to merge 1 commit intopy-vobject:masterfrom
Conversation
Adds explicit import aliases per https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport.
Author
|
Please LMK if you prefer to use the |
htgoebel
suggested changes
Jan 2, 2025
htgoebel
left a comment
There was a problem hiding this comment.
This adds semantic understood by mypy only. I've never seen this and without your link to teh mypy documentation I'd say, this is bad code.
__all__ is much more commonly used and much more understood. I suggest using that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit import aliases per
https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport.
Fixes #53.