Fix description for array-like fields#184
Merged
sydney-runkle merged 4 commits intopydantic:mainfrom Apr 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
sergue1
force-pushed
the
fix-array-field-description
branch
from
b9bf601 to
e24b06c
Compare
Contributor
|
I think this also applies to other field - in particular had an error with |
sydney-runkle
approved these changes
Apr 19, 2024
Contributor
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks good, though the line on 313 isn't covered by the newly added test - is it necessary?
Contributor
Author
|
@sydney-runkle , I am a bit confused that 313 line is uncovered: revert it and the newly added test will fail as expected. May be it is an issue with codecov? |
Contributor
|
Huh, odd! Yeah, maybe an issue. I'll see if I can try to skip that check for this PR. |
Contributor
|
Ah ok I think perhaps this is because we changed a line that was not covered before? |
sergue1
force-pushed
the
fix-array-field-description
branch
from
06276f0 to
6e82a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178