Open
Conversation
Contributor
Author
|
I also need to write the tests for it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 95.68% 95.19% -0.49%
==========================================
Files 14 15 +1
Lines 950 978 +28
==========================================
+ Hits 909 931 +22
- Misses 41 47 +6 ☔ View full report in Codecov by Sentry. |
tim-x-y-z
commented
Feb 18, 2024
| colors: string[] | ||
| tooltip?: boolean | ||
| } | ||
| export interface BaseModel {} |
Contributor
Author
There was a problem hiding this comment.
also unsure why this came about - i probably miissed something somewhere
tim-x-y-z
commented
Feb 18, 2024
tim-x-y-z
commented
Feb 18, 2024
| title: str | ||
| width: _t.Union[int, str] = '100%' | ||
| height: _t.Union[int, str] | ||
| data: _t.List[DataPoint] # type: ignore |
Contributor
Author
There was a problem hiding this comment.
is there a better way to do this ?
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is more a proposal at this stage, the initial chart implemented is a line chart - very happy to add more if this template seems acceptable. I can also clean a bit the implementation and add parameters if we want.
Here are a few things to note:
rechartshttps://github.com/recharts/recharts , this might be a downside if we don't want to have dependencies ? (in particular, this first pr only does the line chart examples here)json_schema_extras- not sure how to decide, probably for the the maintainer to decide.100%in height the graph never stops - i am missing something to understand why.For now here is how it looks:

PS: i hope this can be useful, i would really love to see charts in fastui :)