Conversation
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
Hi @sergue1,
Thanks for your contribution here! We're excited about this fix! I think we should go about the internals of the fix a bit differently, but the demo and tests look good.
| @@ -154,7 +154,8 @@ def json_schema_obj_to_fields( | |||
| required = set(schema.get('required', [])) | |||
There was a problem hiding this comment.
Can we instead make bool fields not required by default?
There was a problem hiding this comment.
I'm not sure I understand, because this is what PR already implements: bool fields are not required. Maybe you mean with "not required by default" that there should be a possibility to make bool field required if necessary? Or set bool field to non required somewhere else, e.g. here?
There was a problem hiding this comment.
Yeah my apologies, my feedback was a bit confusing. Let me dig around this weekend and see if I can better understand how we might be able to fix this in a slightly different way!
Great work so far!
2 participants
Fixes #277.