Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 95.68% 97.01% +1.33%
==========================================
Files 14 15 +1
Lines 950 1173 +223
==========================================
+ Hits 909 1138 +229
+ Misses 41 35 -6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
It can be useful to display invalid messages for select fields when their validation depends on another field.
Before:

After:

For this error 422:
{ "detail": { "form": [ { "type": "text", "loc": [ "text_field" ], "msg": "Text field error" }, { "type": "select", "loc": [ "select_single" ], "msg": "Select field error" } ] } }We could go further and display the border in red like the text field, but that doesn't seem trivial.