Skip to content

Make _client depend on the _transports package instead of its submodules - #1115

Merged
Kludex merged 1 commit into
pydantic:mainfrom
hoodmane:fix-transports-import
Aug 6, 2026
Merged

Make _client depend on the _transports package instead of its submodules#1115
Kludex merged 1 commit into
pydantic:mainfrom
hoodmane:fix-transports-import

Conversation

@hoodmane

@hoodmane hoodmane commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Split from #1022

Review in cubic

@hoodmane hoodmane mentioned this pull request Aug 5, 2026
3 tasks
@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing hoodmane:fix-transports-import (b6dca55) with main (5d9eedc)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@hoodmane
hoodmane force-pushed the fix-transports-import branch from 6646146 to b6dca55 Compare August 5, 2026 22:25
@Kludex Kludex changed the title Import transports from _transports not from _transports.default Import transports from the _transports package in _client Aug 6, 2026
@Kludex Kludex changed the title Import transports from the _transports package in _client Make _client depend on the _transports package instead of its submodules Aug 6, 2026
@Kludex
Kludex merged commit e0b0124 into pydantic:main Aug 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants