Skip to content

Add SSE chunking benchmark - #1116

Merged
Kludex merged 1 commit into
mainfrom
worktree-rippling-bouncing-hare
Aug 6, 2026
Merged

Add SSE chunking benchmark#1116
Kludex merged 1 commit into
mainfrom
worktree-rippling-bouncing-hare

Conversation

@Kludex

@Kludex Kludex commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a benchmark for SSE events split across many chunks before a line separator.
  • Exercise the public EventSource API so the benchmark reflects user-facing behavior.

Motivation

Track SSE parsing performance for highly fragmented event streams.

Validation

  • uv run pytest tests/test_benchmark.py::test_bench_sse_many_chunks_without_line_separator -q
  • Ruff formatting and lint checks
  • mypy

Review in cubic

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

@Kludex
Kludex enabled auto-merge (squash) August 6, 2026 08:01
@Kludex
Kludex merged commit 9849196 into main Aug 6, 2026
16 checks passed
@Kludex
Kludex deleted the worktree-rippling-bouncing-hare branch August 6, 2026 08:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2c0051cdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_benchmark.py
benchmark(split)


def test_bench_sse_many_chunks_without_line_separator(benchmark: BenchmarkFixture) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Attribute the commit to the engineer

The reviewed commit records Codex <codex@openai.com> as both author and committer, but the root AGENTS.md requires authorship to belong only to the engineer. Recreate this commit with the engineer's attribution before merging.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks
🆕 1 new benchmark
⏩ 7 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation test_bench_sse_many_chunks_without_line_separator N/A 3.1 s N/A

Comparing worktree-rippling-bouncing-hare (d2c0051) with main (e0b0124)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant