This repository was archived by the owner on Aug 15, 2021. It is now read-only.
add RawValue for deferring/omitting serde-ing#211
Open
CobaltCause wants to merge 1 commit intopyfisch:masterfrom
Open
add RawValue for deferring/omitting serde-ing#211CobaltCause wants to merge 1 commit intopyfisch:masterfrom
CobaltCause wants to merge 1 commit intopyfisch:masterfrom
Conversation
Unfortunately this requires some unsafe, but fortunately it's only two lines and it's very easy to follow. There are some problems still though, such as not being able to deserialize to a `&RawValue` and `Box<RawValue>`'s deserialize impl doing a roundtrip through `Value`. `RawValue` could probably also be made available on alloc-only no-std platforms, but I'm leaving it at std-only for now just in case I'm wrong. That aside, it does what it's supposed to do, so that's nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this requires some unsafe, but fortunately it's only two lines and it's very easy to follow. There are some problems still though, such as not being able to deserialize to a
&RawValueandBox<RawValue>'s deserialize impl doing a roundtrip throughValue.RawValuecould probably also be made available on alloc-only no-std platforms, but I'm leaving it at std-only for now just in case I'm wrong.That aside, it does what it's supposed to do, so that's nice.
Also, it seems like this repository won't be getting any new activity but I thought I'd open this PR just for visibility if nothing else.