Remove overrides in pyproject.toml to re-enable numpy tests - #3956
Remove overrides in pyproject.toml to re-enable numpy tests#3956bitwise-rude wants to merge 5 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe cibuildwheel override selector now uses the equivalent ChangesWheel build testing
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The selector update retains the intended manylinux coverage for CPython 3.14 and 3.15, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -151,9 +151,8 @@ only-binary = ["numpy"] | |||
| # 2. skip all pypy+arm combinations | |||
| # 3. skip pypy 3.11 manylinux and cpython 3.14 manylinux (numpy has newer manylinux | |||
There was a problem hiding this comment.
Re-add cp315-manylinux_* as an exception for the same reason we had to skip 3.14 manylinux
There was a problem hiding this comment.
numpy's new manylinux builds use manylinux 2_27 but we still use manylinux2014
There was a problem hiding this comment.
Got it! Just pushed the fix. Thank you!
There was a problem hiding this comment.
One last request: Update this comment to make it 3.14+ instead of just 3.14 to be clear about it
There was a problem hiding this comment.
Ok! Pushed the change with update.
oddbookworm
left a comment
There was a problem hiding this comment.
Approving, but I do have one more small thing I'd like to see
| @@ -151,9 +151,8 @@ only-binary = ["numpy"] | |||
| # 2. skip all pypy+arm combinations | |||
| # 3. skip pypy 3.11 manylinux and cpython 3.14 manylinux (numpy has newer manylinux | |||
There was a problem hiding this comment.
One last request: Update this comment to make it 3.14+ instead of just 3.14 to be clear about it
|
Thanks! 🎉 |
Removes the
cp315-*override selector from cibuildwheel configuration in pyproject.toml now that NumPy released Python 3.15 wheels.Closes #3906