Skip to content

Remove overrides in pyproject.toml to re-enable numpy tests - #3956

Open
bitwise-rude wants to merge 5 commits into
pygame-community:mainfrom
bitwise-rude:fix-cp315-numpy-test
Open

Remove overrides in pyproject.toml to re-enable numpy tests#3956
bitwise-rude wants to merge 5 commits into
pygame-community:mainfrom
bitwise-rude:fix-cp315-numpy-test

Conversation

@bitwise-rude

Copy link
Copy Markdown

Removes the cp315-* override selector from cibuildwheel configuration in pyproject.toml now that NumPy released Python 3.15 wheels.

Closes #3906

@bitwise-rude
bitwise-rude requested a review from a team as a code owner September 3, 2026 18:46
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: e8054ba4-94d4-481b-b184-c0bb043ec97b

📥 Commits

Reviewing files that changed from the base of the PR and between 2eed5d9 and 6bd23b7.

📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The cibuildwheel override selector now uses the equivalent cp3{14,15}-manylinux_* pattern. It still applies the empty test dependency list only to CPython 3.14 and 3.15 manylinux builds.

Changes

Wheel build testing

Layer / File(s) Summary
Manylinux selector configuration
pyproject.toml
The selector uses the shorthand cp3{14,15}-manylinux_* pattern. Matching behavior remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6bd23

The selector update retains the intended manylinux coverage for CPython 3.14 and 3.15, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title states that the override was removed and NumPy tests were re-enabled, but the changes only rewrite an equivalent selector pattern. The title does not describe the actual changeset. Update the title to describe the selector-pattern rewrite, or remove the CPython 3.15 exclusion so the current title becomes accurate.
Linked Issues check ⚠️ Warning The pull request does not satisfy issue #3906. The cp315 exclusion remains in the selector, normal test dependency installation is not restored, and no evidence confirms the affected CI jobs pass. Remove cp315 from the cibuildwheel override selector, confirm compatible NumPy release wheels for the required CPython 3.15 targets, and verify the affected wheel-build CI jobs.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description addresses the relevant cibuildwheel, NumPy, and CPython 3.15 topic and links issue #3906. It incorrectly states that the cp315 selector was removed, but the description is related to t…
Out of Scope Changes check ✅ Passed The changes are limited to the cibuildwheel selector in pyproject.toml, which is the affected area named by issue #3906. No unrelated code changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread pyproject.toml Outdated
@@ -151,9 +151,8 @@ only-binary = ["numpy"]
# 2. skip all pypy+arm combinations
# 3. skip pypy 3.11 manylinux and cpython 3.14 manylinux (numpy has newer manylinux

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add cp315-manylinux_* as an exception for the same reason we had to skip 3.14 manylinux

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy's new manylinux builds use manylinux 2_27 but we still use manylinux2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Just pushed the fix. Thank you!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request: Update this comment to make it 3.14+ instead of just 3.14 to be clear about it

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Pushed the change with update.

Comment thread pyproject.toml Outdated

@oddbookworm oddbookworm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I do have one more small thing I'd like to see

Comment thread pyproject.toml Outdated
@@ -151,9 +151,8 @@ only-binary = ["numpy"]
# 2. skip all pypy+arm combinations
# 3. skip pypy 3.11 manylinux and cpython 3.14 manylinux (numpy has newer manylinux

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request: Update this comment to make it 3.14+ instead of just 3.14 to be clear about it

@oddbookworm

Copy link
Copy Markdown
Member

Thanks! 🎉

Comment thread pyproject.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the cibuildwheel CPython 3.15 exclusion after NumPy publishes wheels

3 participants