Remove tune matching from best knowledge model#241
Open
awegsche wants to merge 2 commits into
Open
Conversation
there were two issues: - if we match the tunes, MQT settings will be overwritten and it's not our 'best knowledge' anymore - the tune matching calls `USE` internally, which deletes the b2 errors
Member
|
Will there be any problem if we only use the b2 but don't extract the MQTs? We will not have a matched tune then? |
JoschD
approved these changes
Mar 30, 2023
Contributor
Author
|
After discussion, I will add an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there were two issues:
USEinternally, which deletes the b2 errors