Repository navigation
Conversation
Spectra whose arrays use any MS-Numpress compression term failed to decode: linear and slof raised AttributeError on the removed calling_instance attribute, and pic plus the three 'followed by zlib' terms (MS:1002746-MS:1002748) were not recognized and raised ValueError: Unsupported data type: None. Map all six CV terms to their decoder, zlib-decompress first where the term says so, return the decoded array directly, and support the pure Python fallback.
scan_time_in_minutes() raised 'Time unit unicorns unknown' when the scan start time cvParam had a unitAccession but no unitName (unitName is optional in the mzML schema), raised for millisecond because of an if that should be elif, and raised AttributeError for spectra without a scan start time. Fall back to the UO accession for the unit name, fix the elif, and return None when there is no scan start time.
pymzML always fall back to the default obo and never parsed the correct one from the mzML file.
Read scan time unit from unitAccession, handle missing scan time
Fix decoding of MS-Numpress encoded spectra
Fix faulty default psi-ms CV fallback
|
StSchulze
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.