Add verbosity handling and pass through to pypa/build - #363
Conversation
for more information, see https://pre-commit.ci
|
I have set up the plumbing here but |
|
The logger is indeed not set up correctly, as pypa/build uses print calls and it prints to |
ryanking13
left a comment
There was a problem hiding this comment.
Thanks for handling this. I left some comments but overall it looks good to me
| yield env | ||
|
|
||
|
|
||
| def _make_pypa_build_logger() -> Callable[[str], None]: |
There was a problem hiding this comment.
Maybe this can be moved to vendor/_pypabuild as well.
There was a problem hiding this comment.
Hmm, I'd like to keep this one here itself, as it's something that we are implementing (even though we keep it private). It is not vendored from pypa/build.
|
Thanks for reviewing! |
I finally decided to take up #222. This PR exposes verbosity via
-vand-vvCLI flags (stackable). They are passed along to pypa/build's_ctx.VERBOSITY. It controls pypa/build's own subprocess calls for uv/pip installs. Build backend commands (meson, cmake, gcc wrappers, etc.) are always visible regardless of verbosity.Closes #222
TODO: