Explicitly reject oldest-supported-numpy as a build-time dependency - #392
Merged
Conversation
agriyakhetarpal
changed the title
oldest-supported-numpyoldest-supported-numpy as a build-time dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #21.
oldest-supported-numpyis no longer silently ignored when it appears as a build dependency, and instead raises an error. It has been deprecated since NumPy 2.0, so packages that still depend on it should move to a plainnumpydependency. If this causes trouble for a specific recipe, it can still be ignored by settingignored_build_requirementsto"patchelf oldest-supported-numpy"of course, but IMO we don't need to bother about it anymore. In pyodide/pyodide-recipes#591, I tested the change via #21, only Fiona was using it. I updated its version to one that no longer uses it in pyodide/pyodide-recipes#608 and all recipes are now fine.