Bump pygame-ce to 2.5.6.dev2 - #388
Merged
Merged
Conversation
ryanking13
marked this pull request as ready for review
October 15, 2025 13:33
Member
Author
|
Okay, looks like it works fine with the demo examples: https://ryanking13.github.io/pyodide-pygame-demo/ |
Contributor
Package Build ResultsTotal packages built: 28 Package Build Times (click to expand)
Longest build: pygame-ce (4m 10s) |
ankith26
reviewed
Oct 15, 2025
| post: | | ||
| # Remove docs to reduce the size of a wheel | ||
| # (Perhaps also remove typeshed and examples too?) | ||
| rm -rf ./pygame/docs |
Contributor
There was a problem hiding this comment.
This is not necessary, the docs are already removed by default in the emscripten build on our side
Member
Author
There was a problem hiding this comment.
That's a good to know. Thanks!
Co-authored-by: Ankith <itsankith26@gmail.com>
Removed post-build step to delete documentation.
ryanking13
added a commit
that referenced
this pull request
Oct 17, 2025
Co-authored-by: Ankith <itsankith26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies pygame-community/pygame-ce#3588
Maybe I should update pygame-ce cibuildwheel setting to include the WASM wheel to their releases. Let me do that as a follow-up. For now, let's build it ourselves.
Opening as a draft, as I haven't verified it with real examples yet.