test: add test for building with unicode filenames#355
Open
test: add test for building with unicode filenames#355
Conversation
takluyver
reviewed
Jun 16, 2020
tests/test_build.py
Outdated
| files = [ | ||
| 'pyproject.toml', | ||
| 'packageunicode/__init__.py', | ||
| u'packageunicode/No\\u00ebl.jpg', |
Member
There was a problem hiding this comment.
Suggested change
| u'packageunicode/No\\u00ebl.jpg', | |
| 'packageunicode/No\\u00ebl.jpg', |
We don't need to worry about Python 2 here. :-)
Contributor
Author
There was a problem hiding this comment.
I’m trying to figure out why the appveyor ci is failing. The tests all run successfully locally with tox.
bpabel
force-pushed
the
add-unicode-tests
branch
from
5cf1d2d to
411e6c5
Compare
bpabel
force-pushed
the
add-unicode-tests
branch
from
411e6c5 to
9185838
Compare
This comment was marked as spam.
This comment was marked as spam.
Member
|
Let's see how this goes with the current test pipeline. |
Member
|
Still no dice: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an explicit test for building against unicode filenames that I neglected to add with the last PR.