Repository navigation
Make doctest table formatting independent of terminal width - #410
Merged
Merged
Conversation
Collaborator
Author
|
Thanks, I can confirm the tests run fine on my end now 🙏 |
Collaborator
Author
|
Thanks for reporting. Make sure to try the new version or start new projects with it perhaps :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
pytest --doctest-modules pyrangesin a narrow or headless environment can hide table columns and fail doctests, even though the values are unchanged. GitHub CI masked this because the formatter forces a 250-column width wheneverGITHUB_ACTIONSis set.Set
COLUMNS=250in an autouse fixture restricted to doctest items. Ordinary tests and normal library display keep their existing settings. Run CI doctests withGITHUB_ACTIONSunset and an initial 80-column width so the GitHub-only workaround can no longer hide this regression.Validation:
GenomicFeaturesMethods.tssfailure atCOLUMNS=80withGITHUB_ACTIONSunset.COLUMNS=250 pytest --doctest-modules pyrangesis a working workaround for the existing 0.1.6 source (87 passed).git diff --checkpass for the change.