Repository navigation
Require stride-aware backends for pandas 3.1 - #412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandas 3.1 can return non-contiguous arrays from Series.values, which older ncls, sorted_nearest and pyrle kernels reject. Require the fixed backend versions so k_nearest, overlap, subtraction and coverage work without adding copies throughout PyRanges.
Bumps PyRanges to 0.1.7 and requires ncls >= 0.0.71, sorted_nearest >= 0.0.42 and pyrle >= 0.0.46 for the coverage extra.
Prerequisites: merge and publish the backend fixes before merging/releasing this dependency update:
Validation: smoke-tested k_nearest, overlap, join, subtract, coverage and to_rle on Python 3.12 / pandas 3.1.0 with wheels built from those fixes. The older k_nearest.py tests retain three pre-existing int32-versus-int64 fixture mismatches, reproduced with the previous backend/PyRanges versions; those fixtures are unchanged here.
CI now tests Python 3.11 and above and installs pinned companion backend PR revisions before their releases are available on PyPI. Add a local tests package marker so dependency test packages cannot shadow tests.helpers. Local validation: 87 doctests and 40 unit tests pass.