Repository navigation
Fix fisher_exact docstring example and release 1.5.2 - #212
Merged
Merged
Conversation
The example passed TN before FN, but the signature is fisher_exact(tp, fp, fn, tn). Port of pyranges/pyranges0#411. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YSQEBfFhfhK1o1XRsbHtcP
Bump the version and add the fisher_exact docstring fix to CHANGELOG.txt and the README changelog. The fix was found and made by Mohit Arvind Khakharia (@Mohit-Ak) in pyranges/pyranges0#411; this branch ports it. The README changelog also gains the missing 1.5.1 entry. Co-authored-by: Mohit Arvind Khakharia <6740115+Mohit-Ak@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
endrebak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports pyranges/pyranges0#411 by @Mohit-Ak, who found and fixed this: the
fisher_exactdocstring example passed TN before FN, but the signature isfisher_exact(tp, fp, fn, tn), so it showed the odds ratio and p-values for the wrong table.Also releases 1.5.2:
pyproject.tomlCHANGELOG.txtand the README changelogThe release commit has a
Co-authored-bytrailer for @Mohit-Ak, so a squash merge keeps the credit.Full tox suite passes locally (py312).
🤖 Generated with Claude Code