Repository navigation
Conversation
Contributor
Author
|
Fixed the CI architecture-ratchet failure ( The failing CI run had 8,775 passing tests and this one failure. After reproducing it locally, the JSON-output, QA, URL-checker tests plus the architecture assertion pass: 49 passed. Ruff check and format check pass. The uploaded tree at |
ANO3457
marked this pull request as ready for review
October 2, 2026 18:49
Collaborator
|
Meets #611's acceptance points. Small things:
Automated review by an agent for the maintainer; comment only. |
* test: cover retryable URL collection database locks * test: cover retryable URL collection database locks * fix: share URL collection storage error translation * docs: clarify URL type coverage and retryable locks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #611.
Plan / claim
Claimed #611 after #604/#574 landed. This covers the groomed output, failure and source-discovery theme in one PR.
Testing
pytest tests/test_json_stdout.py tests/test_qa_commands_run.py tests/test_url_checker.py -q. Tests use the root CLI and real SQLite-backed QA reports, forced color, a 40-column terminal, long bracket titles, and mocked HTTP.git diff --checkpassed.scripts/test-affected --base upstream/dev --run -n 4run on Windows did NOT pass: 4049 passed, 152 failed, 107 skipped, 897 errors. Visible failures include unavailable POSIXfcntl, missing extension installs, and SQLite file-lock teardown errors (WinError 32). I am not claiming a clean broad local suite; Linux CI is still needed.Notes for the reviewer
The existing 10,000-entry limit remains per entry type, including newly discovered types. A type with more than 10,000 entries can still be truncated; this PR does not add pagination. A mixed-type query-limit regression protects other types from being hidden by 10,000 newer documents.
Cold review caught a draft implementation that accidentally made this cap global; it was corrected before submission. The final four-file remote diff matches the tested local content. A changelog fragment is included.