[ANO3457]

Fixes #737

CONTRIBUTING owns CI-scoped lint, test commands and the installed hook-stage table. Other pages point there; targeted diagnostic examples are explicitly labeled. git-workflow remains a searchable pointer, with superseded_by metadata, rather than obsolete release/pytest-hook instructions. CLAUDE changes are restricted to Testing and Pre-commit Hooks. KB bodies/metadata were edited through pyrite update.

The newer #425 foreground, one-suite-at-a-time instruction is retained. Background-run guidance is conditional and requires the final summary plus exit status, never a second overlapping suite. No hook, CI or deploy code changes. Whether deploy/appointee code should join the Ruff scope remains a separate maintainer question.

Verification: 3 new documentation guards failed before edits; 32 focused portable configuration/documentation checks now pass. Exact CI Ruff check and format scopes pass (709 files formatted). The full test_dev_process_config.py run was not clean on Windows: 127 passed/24 failed, including 23 shell/executable tests and the then-unfixed documentation encoding guard; the encoding guard was corrected and the 32-test subset rerun. No full-suite or upstream CI pass claimed. AI-assisted with Codex; self-reviewed; draft pending upstream checks/review.

[markramm]

Automated review. I'm an AI agent that triages pull requests for this project's maintainer. A person reads these and makes the final call. If I've got something wrong, say so here.

Thank you for taking on #737 and for the careful write-up.

It was reviewed as ready because CI is green and the work looks complete; you can mark it ready for review when you agree.

Matches the issue: CONTRIBUTING gains a ## Lint section with CI's exact command, other pages point to it, git-workflow becomes a pointer, and three guards in tests/test_dev_process_config.py pin the lint command, the "one home" rule and the hook stages.

Differs from the groom:

• Groom: SKILL.md "says to start test-affected --run alone in the background and read its summary line." The PR keeps SKILL.md:128's foreground rule and CONTRIBUTING says foreground, background only if needed, citing #425 (opened 2026-09-25, before the groom; it has no decision comment).
• Groom: "Must not change: … the conductor skills (… give them a link only…)". pyrite-meta-conductor/SKILL.md:74-75 swaps --durations=15 and ruff --statistics for a pointer to sections that do not contain them.

Overlaps other open PRs: #723 rewrites the CLAUDE.md hooksPath line this PR deletes, and removes setting-up-dev-environment.md steps 1–5, including the Verify step edited here. #751 adds a goldens subsection inside the README Development section, which this PR replaces. #801 edits the adjacent README docs list. #887, #886 and #830 touch separate sections.

Property coverage: these still name an old command or the removed pytest hook: CONTRIBUTING.md:99,102 (ruff check pyrite/), .claude/skills/pyrite-dev/testing.md:269, .claude/skills/pyrite-dev/extensions.md:398, kb/runbooks/setting-up-dev-environment.md:54. The guard skips CONTRIBUTING and matches only at line start, so it misses these.

Tests: by reading, all three guards fail on dev.

Needed before merge

1. Rebase onto dev; dev's CLAUDE.md Pre-commit section now also has a "verified commit" paragraph.
2. Point CONTRIBUTING.md:97-105 at #lint.
3. Remove the pytest-hook lines listed above.
4. Carry the core.hooksPath workaround and the "re-run pre-commit install if installed before 2026-09-17" note into CONTRIBUTING. Today they exist only in the CLAUDE.md text being removed.

This touches more than 10 files, so the merge is the maintainer's.

Recommendation: needs the maintainer's decision on whether pyrite-dev keeps the foreground test-affected --run rule (#425) or adopts the groom's background-and-read-the-summary instruction.
The maintainer makes the final call.

---

Generated by Claude Code

[markramm]

This branch now conflicts with dev. We'd be glad to rebase it for you, but "Allow edits by maintainers" is off for this PR, so we can't push to the branch. Could you either tick that box (in the right-hand sidebar of the PR) or rebase it yourself? Thanks.

[markramm]

@ANO3457, a scheduling note: this has been waiting on you for about a week. If we haven't heard from you by 2026-10-21, the maintainers will either carry it (your commits and credit kept) or close it so the queue stays current. Either way it can be reopened. Thanks for all the work across these PRs.

[markramm]

Maintainer decision (2026-10-17): pyrite-dev keeps the foreground test-affected --run rule (#425); the groom's background-and-read-the-summary instruction is withdrawn. The review's other items (the meta-conductor lines, and the old ruff check pyrite/ commands its guard misses) still stand. Then rebase onto dev.

---

🤖 Posted by the maintainer's conductor agent (Claude Code)

[markramm]

The 0.26 architecture sprint landed on dev on 10-19, after this PR was opened. Every write now applies operations to the file's text (ADR-0042: file_operations.apply → entry_writer.publish_entry_text, and KBRepository.save is create-only), metadata.k is a second spelling of k (ADR-0051), one resolver answers "which KB", and the Streamlit UI, /site and the cascade extension are gone. Details are in the Discussions announcement. Sorry this landed on top of your work without warning.

@ANO3457: still needed (the lint lines still disagree). The rebase is heavier than usual: #929/#939 cut CLAUDE.md to 25 lines, and the conductor skills moved out of the repo, so those hunks drop. Keep the foreground test-affected --run rule (10-17 decision), and catch the remaining ruff check pyrite/ lines.

If we don't hear from you by 2026-10-21, the maintainer's agent will carry it: rebase it, make these changes, and land it with your commits and a Co-authored-by line, so the credit stays yours. If you'd rather finish it yourself, just say so here.

🤖 Posted by the maintainer's conductor agent (Claude Code)

[markramm]

@ANO3457, a reminder of the maintainer's 10-17 decision: pyrite-dev keeps the foreground test-affected --run rule (#425); the background-and-read-the-summary instruction is withdrawn. With that applied and a rebase onto dev, this is ready.

🤖 Posted by the maintainer's conductor agent (Claude Code)