gh-143959: Split datetime tests requiring _datetime #143997
Open
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test-only change; no user-visible impact, so no NEWS entry is needed. |
serhiy-storchaka
added
skip news
needs backport to 3.13
Lib/test/test_datetime.py
Outdated
| fast_tests = import_fresh_module(TESTS, | ||
| fresh=['datetime', '_strptime'], | ||
| blocked=['_pydatetime']) | ||
| pure_tests = import_fresh_module( |
Member
There was a problem hiding this comment.
You can now restore the old formatting.
Contributor
Author
There was a problem hiding this comment.
Thanks — I’ve restored the original formatting.
Member
There was a problem hiding this comment.
It is not restored yet.
Contributor
Author
There was a problem hiding this comment.
I’ve now restored the original structure by keeping the two import_fresh_module() calls adjacent and moved the _datetime availability check outside that block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the datetime tests into two groups:
_datetime_datetimeThe
_Fasttests are only loaded when_datetimeis available, allowingthe test suite to run correctly on builds where
_datetimeis not present.No test behavior is changed.