Skip to content

gh-144001: Support ignorechars in binascii.a2b_base64() and base64.b64decode() #144024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
serhiy-storchaka wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gh-144001: Support ignorechars in binascii.a2b_base64() and base64.b64decode() #144024

serhiy-storchaka wants to merge 1 commit into from
+231 −101

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 19, 2026 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 19, 2026
Open
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jan 19, 2026

This is a draft because I am going to apply the error handling changes in a separate issue first.

We can also apply some optimizations -- cache the ignored chars and returning on fast path after ignored characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serhiy-storchaka