windows-release/tcltk-build: Update to handle Tcl/Tk 9#378
Conversation
zware
commented
May 6, 2026
- tcltk-build: Remove Tix
- tcltk-build: Split {Tcl,Tk}SourceTag into version and prefix parameters
|
Apart from the CI failure, looks good to me. I guess they need some better cross-compiling support, but hopefully you can override a build variable to get it to use the Win32 build during the ARM64 one? |
|
Yep, looking into what else needs the override now. |
|
Another trick we could use here is to extract the version number from the header file, that way we can go back to setting just the tags when building: $ver = @{}
Get-Content .\generic\tcl.h | ?{ $_ -match '#\s*define\s+TCL_([A-Z]+)_VERSION\s+(\d+).*'} | %{ $ver[$Matches[1]] = $Matches[2] }
$ver.MAJOR
$ver.MINORThat doesn't help people trying to build separately (without this script), but the current change doesn't help them either. |
|
Hmm, could we actually do that in I think this is ready to go, but I'd rather someone else hit the big green button in this repo :) |
Not so easily without adding more build-time dependencies (such as shelling out to Powershell or Python to do the command and print each variable one at a time - parsing stuff in MSBuild is a pain). It would be easier to use more wildcards and fewer hard-coded assumptions about the Tcl and Tk builds' outputs.
Have you been able to run test builds of it directly from this branch? It's possible, and I assume you've got the permissions, but if that's been fine then it's fine by me. |
|
Yes; see test build (unsigned), python/cpython#149477 for CI against it (using my fork of cpython-bin-deps). |
|
Done. I'm off for the night now though, so if you start a signed build immediately you'll have to hope Hugo is about to approve it, or I'll do it tomorrow. |
|
Thanks! |